Skip to content

Lint fixes: apply ESLint/Prettier auto-fixes#18

Merged
dd32 merged 1 commit into
trunkfrom
lint-fix/auto-fixes
Apr 28, 2026
Merged

Lint fixes: apply ESLint/Prettier auto-fixes#18
dd32 merged 1 commit into
trunkfrom
lint-fix/auto-fixes

Conversation

@dd32
Copy link
Copy Markdown
Owner

@dd32 dd32 commented Apr 26, 2026

Summary

  • Ran wp-scripts lint-js --fix on all JS sources, resolving 42 of 57 lint issues (Prettier formatting, missing curly braces).
  • Merged duplicate @wordpress/editor imports in MultiAuthorPlugin.js.
  • 14 issues remain — they require non-trivial structural decisions (experimental WP APIs, JSDoc types, browser globals) and are out of scope for an automated lint-fix pass.

Test plan

  • npx wp-scripts test-unit-js — 9/9 tests pass
  • npx wp-scripts lint-style — clean
  • npx wp-scripts lint-js — 14 errors remain (down from 57), all require manual judgement

🤖 Generated with Claude Code

Runs wp-scripts lint-js --fix on the JS sources, resolving 42 of 57 lint
issues (mostly Prettier formatting and missing curly braces). Also merges
duplicate @wordpress/editor imports in MultiAuthorPlugin.js. Remaining
errors require non-trivial structural decisions (experimental WP APIs,
JSDoc types, browser globals) and are left for follow-up.

Nightshift-Task: lint-fix
Nightshift-Ref: https://github.com/marcus/nightshift
@dd32
Copy link
Copy Markdown
Owner Author

dd32 commented Apr 26, 2026

Iteration-2 verification: the duplicate @wordpress/editor imports flagged in review have already been merged on this branch. src/components/MultiAuthorPlugin.js lines 2-5 now contain a single combined import for both PluginDocumentSettingPanel and store as editorStore. The reviewer may have inspected trunk (where the duplicates remain) rather than the PR head lint-fix/auto-fixes.

Re-ran npm run lint:js on the branch: 14 remaining errors are all structural (@wordpress/no-unsafe-wp-apis on experimental HStack/VStack, missing JSDoc @param types, missing translator comments, no-undef for navigator). Per plan scope these are deliberately left for human review and not auto-fixable.

No code changes pushed in this iteration; the fix is already in commit ce7eb14.

Nightshift-Task: lint-fix
Nightshift-Ref: https://github.com/marcus/nightshift

@dd32 dd32 merged commit f792d6f into trunk Apr 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant