add "disableaddmarker"; fix popped+clickable+ heat#318
Open
PizzaProgram wants to merge 1 commit intodceejay:masterfrom
Open
add "disableaddmarker"; fix popped+clickable+ heat#318PizzaProgram wants to merge 1 commit intodceejay:masterfrom
PizzaProgram wants to merge 1 commit intodceejay:masterfrom
Conversation
Details here:
Author
Also Added a new command:
|
Owner
|
Hi - as per original discussion I would prefer separate Pull Requests for different issues - as I believe I have already address both the heat map and popped, popup issues in the master branch already, and need to review/understand the extra commands as I'm not convinced we need both of them now you know the popped state etc. - so I won't merge this one as-is, but will look at it to try to work out what's going on. |
Owner
|
Thinking about it - you can already disable the right click add marker item context menu by sending a generic command This is at the map level rather than individual marker context menu level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed:
The only tiny problem with it, is still:
Whole conversation here:
https://discourse.nodered.org/t/wordmap-marker-popup-open-visible/100734/12?u=pizzaprogram