Draft
Conversation
rollf
commented
Sep 8, 2025
| bang = true, | ||
| }) | ||
|
|
||
| vim.api.nvim_create_user_command("AllFormatDisable", function() |
Author
There was a problem hiding this comment.
I'd rather have this block somewhere else. Technically, it does neither belong to the convirm nor the lsp-format plugin. I did not see an obvious candidate for this extra config lua section.
Author
|
@dc-tec Have you seen this PR here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #91. This is done by renaming the user-defined
conform.nvimfunctionsFormatEnable/Disable/ToggletoConformFormatEnable/Disable/Toggle. Doing so allows to access other functions namedFormat...which are provided in the global name space bylsp-format.nvim. The function names where the same.In a second step, new functions are added, namely
AllFormatEnable/Disable/Togglewhich invoke the corresponding functions for both plugins. Thus, a single command can be used to change the behavior of both plugins.lsp-format.nvim does not (yet?) allow disabling on a per-buffer basis. The
All...functions do not differentiate between all or current buffer neither.Renaming the functions is a breaking change. Anyone having mapped those function will now invoke the "wrong" ones (previously, the conform.nvim functionality was accessed, now it would be the one from lsp-format.nvim).