dbeaver/pro#9617 api for data-import settings#4423
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 11 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
HocKu7
force-pushed
the
dbeaver/pro#9617-api-for-data-import-settings
branch
from
4d42e29 to
edee7d9
Compare
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class WebDataImportSettings { |
There was a problem hiding this comment.
We discussed and stated that we don't want to have data import settings.
It is datasource settings, similar to dialect.
Name it WebDriverConfiguration, put all settings there: replace methods, bulk load support, transaction support. We'll add many more in future
| "Supported 'on duplicate key' replace methods for this connection's SQL dialect" | ||
| onDuplicateKeyMethod: [DriverConfigurationValueInfo!]! | ||
| "Whether the connection's database supports bulk load during data import" | ||
| useBulkLoad: Boolean! |
| "Whether the connection's database supports bulk load during data import" | ||
| useBulkLoad: Boolean! | ||
| "Whether the connection's database supports transactions" | ||
| useTransactions: Boolean! |
| "Database-dependent metadata describing the driver configuration" | ||
| type DriverConfiguration { | ||
| "Supported 'on duplicate key' replace methods for this connection's SQL dialect" | ||
| onDuplicateKeyMethod: [DriverConfigurationValueInfo!]! |
There was a problem hiding this comment.
-> supportedInsertReplaceMethods
| driverConfiguration: DriverConfiguration! @since(version: "26.1.2") | ||
| } | ||
|
|
||
| "Database-dependent metadata describing the driver configuration" |
There was a problem hiding this comment.
describing features supported by the driver
| } | ||
|
|
||
| "Generic metadata of a single allowed value (option) of a driver configuration setting" | ||
| type DriverConfigurationValueInfo { |
There was a problem hiding this comment.
-> DictionaryValueInfo (it is a generic type which can be used in different places))
| @NotNull DBSDataManipulator dataContainer, | ||
| @NotNull Path path | ||
| @NotNull Path path, | ||
| @Nullable Map<String, Object> settings |
There was a problem hiding this comment.
Instead of map (how front-end will name names of properties?) you can use GQL input type.
2 participants
Closes https://github.com/dbeaver/pro/issues/9617