dbeaver/pro#8978 paste multiple values#4299
Merged
Conversation
devnaumov
requested review from
SychevAndrey,
Wroud,
Copilot and
sergeyteleshev
and removed request for
Copilot
Up to standards ✅🟢 Issues
|
| updates.push({ key: target, value }); | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
we should do something about this complicated case:
Screen.Recording.2026-04-23.at.10.17.00.mov
Member
Author
There was a problem hiding this comment.
We should not, it works as expected
devnaumov
commented
Apr 23, 2026
Wroud
previously requested changes
Apr 23, 2026
sergeyteleshev
requested changes
Apr 24, 2026
| } | ||
|
|
||
| const getRowIdx = (key: IGridDataKey) => tableData.getRowIndexFromKey(key.row); | ||
| const getColIdx = (key: IGridDataKey) => tableData.getColumnIndexFromColumnKey(key.column); |
Contributor
There was a problem hiding this comment.
We need to consider the cases with the pin columns & reordering of columns:
Screen.Recording.2026-04-24.at.14.06.47.mov
Member
Author
There was a problem hiding this comment.
Its considered, getRowIndexFromKey gives you real index, the same as for copying values
sergeyteleshev
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes 8978