Dbeaver/cloudbeaver#4120 support token header#4259
Open
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 critical |
🟢 Metrics 0 complexity · -2 duplication
Metric Results Complexity 0 Duplication -2
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
yagudin10
previously approved these changes
Apr 20, 2026
serge-rider
requested changes
Apr 21, 2026
serge-rider
requested changes
Apr 21, 2026
serge-rider
requested changes
Apr 24, 2026
| protected final ServletApplication application; | ||
| protected volatile long lastAccessTime; | ||
| @NotNull | ||
| private SessionType sessionType = SessionType.WEB; |
Member
There was a problem hiding this comment.
LEts pass it in constructor and make final
|
|
||
| public static final String SECURED_VALUE = "******"; | ||
|
|
||
| public static final String HEADER_API_TOKEN = "X-API-Token"; |
Member
There was a problem hiding this comment.
Maybe we should use HttpConstants.HEADER_API_KEY?
We already have proxy config for it
| session.close(); | ||
| } | ||
|
|
||
| @NotNull |
Member
There was a problem hiding this comment.
Why part of it here and part in pro?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4120