Support a --checkpoint file for batch input
#1466
Merged
+56
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
force-pushed
the
RW/checkpoint-file-for-batch-input
branch
2 times, most recently
from
b68332f to
560ba31
Compare
scottnemes
reviewed
Jan 22, 2026
mycli/main.py
Outdated
| assert self.sqlexecute is not None | ||
| self.log_query(query) | ||
| results = self.sqlexecute.run(query) | ||
| if checkpoint: |
Contributor
There was a problem hiding this comment.
This logs the query before it finishes running; is that the intended use case? I would expect it to log after completion under normal circumstances. If so could be moved down below the for loop and then it will write after. Also would recommend using write instead of print, and you can flush it so the log gets updated right away for tracking purposes:
if checkpoint:
checkpoint.write(query)
checkpoint.flush()
Contributor
Author
There was a problem hiding this comment.
Great catch/es!
Updated, with a test to cover query failure.
rolandwalker
force-pushed
the
RW/checkpoint-file-for-batch-input
branch
2 times, most recently
from
626c8de to
e3b3e04
Compare
scottnemes
approved these changes
Jan 23, 2026
which saves only successful queries, not results.
rolandwalker
force-pushed
the
RW/checkpoint-file-for-batch-input
branch
from
e3b3e04 to
b86cb3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support a
--checkpointfile for batch input which saves only successful queries, not results.The motivation is that a checkpoint file allows an operator to resume an interrupted script. The
--logfileoption is inconvenient for this since it logs results.Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.