Allow table names to be completed with leading schema names #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow table names to be completed with a leading schema name as in
schema.table
Note however that the table names can only be successfully completed
if they are in the currently-selected schema. Completing table names in
another schema is still a todo.
This is a one-line fix that appears to be due to a confusion between
the strings "database" and "schema" in the completion code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow table names to be completed with a leading schema name as in
Note however that the table names can only be successfully completed if they are in the currently-selected schema. Completing table names in another schema is still a todo.
This is a one-line fix that appears to be due to a confusion between the strings "database" and "schema" in the completion code.
Strictly speaking this fixes #1142, but not #109.
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.