Remove quoting on uppercase-identifier completions #1458
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mandatory quoting is retained for identifiers which have any non-alphanumeric characters, but an uppercase character alone does not activate the suggested quoting.
scottnemes
reviewed
Jan 22, 2026
Contributor
There was a problem hiding this comment.
One additional thing I was going to add was escaping database names:
def extend_database_names(self, databases: list[str]) -> None:
self.databases.extend([self.escape_name(db) for db in databases])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory quoting is retained for identifiers which have any non-alphanumeric characters, but an uppercase character alone does not activate the suggested quoting.
The original logic looks intentional but doesn't seem to be needed. Maybe this was because the list of keywords was limited, and capitalization was a proxy for keyword? After #1447, we have a much more complete list of keywords.
Fixes #620.
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.