Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Nov 21, 2025

Proposed changes

Due to the work on PR #5387 we've encountered some pipeline runs that ended up running very long into timeouts. To prevent those we should add the correct category part of the component to the test URLs from the very beginning.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-use-basepath-for-group-in-URL-for-tests

@mfranzke mfranzke self-assigned this Nov 21, 2025
@mfranzke mfranzke added the 🐛bug Something isn't working label Nov 21, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: 4371b02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Nov 21, 2025
@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Nov 21, 2025
Copilot finished reviewing on behalf of mfranzke November 21, 2025 14:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the Patternhub test file where test URLs were missing the component group/category path segment. The tests now correctly use the dynamic group.path value instead of a hardcoded ./components/ prefix.

  • Changes the URL construction in tests to include the full group path from the components.json data structure
  • Ensures test URLs match the actual routing structure (e.g., /components/action/button/... instead of /components/button/...)

@mfranzke mfranzke enabled auto-merge (squash) November 21, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 📺showcases Changes to 1-n showcases

Projects

Status: 🎁 Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants