Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2025

This PR was created automatically by a GitHub Action.

Target PR (this PR will be merged into): #5399

@github-project-automation github-project-automation bot moved this to 🏗 In progress in UX Engineering Team Backlog Nov 3, 2025
@dbux-auto-merge-pr dbux-auto-merge-pr bot merged commit ee7cfbe into fix-tab-item-selected-state Nov 3, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025

⚠️ No Changeset found

Latest commit: acacc59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dbux-auto-merge-pr dbux-auto-merge-pr bot deleted the fix-tab-item-selected-state-auto branch November 3, 2025 13:50
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in UX Engineering Team Backlog Nov 3, 2025
milan-w pushed a commit that referenced this pull request Nov 6, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
milan-w pushed a commit that referenced this pull request Nov 20, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
d-koppenhagen pushed a commit that referenced this pull request Nov 20, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
milan-w pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke pushed a commit that referenced this pull request Nov 26, 2025
* fix: set DBTabItem selected state correctly

Set (aria-)selected state via listener on parent tablist to also react on de-selection of item.

* chore: update DBTab test

use var instead of file to hold click event results for test duration

* Fix DBTabItem selected state and aria-selected attribute

Now also sets aria-selected=true|false correctly which improves screen reader behaviour.

* auto update snapshots (#5400)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: pass correct tab item index from DBTab parent to child

set child active after event registered, remove event listerner on unmount

* auto update snapshots (#5409)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: ensure active/selected state and aria-selected are in snyc

add more checks and guardrails to TabItem on change events

* fix: re-add stencil special boolean treatment in DBTabItem

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant