fix: use Dir instead of Dirs in Cache.FilePath #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Cache.FilePath` method was using the `Dirs` method to find the directory for a given package path, but this can result in cache misses because the `dirsCache` may have been populated using a path pattern (e.g. `./...`) that doesn't match the package directory derived from the file path provided. This can result in a confusing slowdown when you know the package directory is in the cache but `Cache.FilePath` still results in calls out to `go list` to find the directory. The fix is to use the `Dir` method instead of `Dirs` to find the directory for a given package path. I'm assuming that there's no need to support path patterns in `FilePath`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Cache.FilePathmethod was using theDirsmethod to find the directory for a given package path, but this can result in cache misses because thedirsCachemay have been populated using a path pattern (e.g../...) that doesn't match the package directory derived from the file path provided. This can result in a confusing slowdown when you know the package directory is in the cache butCache.FilePathstill results in calls out togo listto find the directory.The fix is to use the
Dirmethod instead ofDirsto find the directory for a given package path. I'm assuming that there's no need to support path patterns inFilePath.