feat: Add the ability to activate a Datum Cloud API Token. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two new auth subcommands have been added: - activate-api-token: Accepts an API token either via stdin or a secure prompt and saves it in the OS keyring. This token will be used to obtain a token compatible with Datum Cloud infrastructure APIs when no service account credentials are located. - logout: Removes an activated token from the OS keyring. Future work will likely come to clean up keyring access when we implement token caching. We may also want to keep an eye on cli/cli#7743 to follow suit if a keyring library switch is made.
scotwells
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new auth subcommands have been added:
Future work will likely come to clean up keyring access when we implement token caching or move from personal access tokens to alternative credential approaches.
We may also want to keep an eye on cli/cli#7743 to follow suit if a keyring library switch is made.