feat: test that a network reaches the cell a workload runs in - #228
Merged
Conversation
The harness installed NSO's CRDs on the control plane and both POP cells but not on the Karmada hub, and installed no NSO propagation policy at all. A NetworkContext is written on the hub and propagated to the cells serving its location, so there was no local path by which one could reach a cell and no way to test the claim path end to end. Install the NSO CRDs on the hub too, apply NSO's own federation propagation policy there, and label the member clusters infra.datum.net/gateways=enabled so that policy actually selects them — it matches nothing without the label, and does so silently. Also grant the hub identity networkbindings on networking.datumapis.com. Compute asks for a network in a location by writing a binding on the hub, and the hub role granted nothing in that group at all.
…ronment Running the local e2e environment required Python plus the PyYAML module, an interpreter dependency unrelated to anything the environment actually tests. Every use is expressible with tools the Taskfile already depends on, so a contributor now needs only go, kubectl, docker, and a POSIX shell. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
scotwells
marked this pull request as ready for review
August 14, 2026 14:38
scotwells
enabled auto-merge
August 14, 2026 14:38
ecv
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A workload gets an address from the network layer at the location it runs in. Nothing in our tests proves that actually happens end to end, because the test environment cannot carry a network's presence from the federation layer down to a cell.
This makes that path exist locally, so the address workloads depend on can be tested rather than assumed.
What changes
Only the test environment and the permission compute needs to ask for a network in a location. No product behaviour, and nothing switched on.
Related