fix: hide disabled plugin database types from connection form picker#239
fix: hide disabled plugin database types from connection form picker#239
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f9c10b9cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !isNew, !enabled.contains(type) { | ||
| return [type] + enabled | ||
| } | ||
| return enabled |
There was a problem hiding this comment.
Reset new-form type when default plugin is disabled
This logic only preserves picker validity for edit mode; in new mode it returns enabled even when the bound type (default .mysql) is no longer present. If MySQL is disabled and the user opens a new connection, the picker options omit MySQL but saveConnection()/testConnection() still read type, so the form can operate on a hidden disabled type unless the user manually changes it. Please ensure new forms also reconcile type to an enabled value when the current selection is missing.
Useful? React with 👍 / 👎.
Summary
loadPendingPlugins()to handle lazy plugin loadingFollow-up to #236.
Test plan