SCCM-1815: Reduce dashboard and server vulnerabilities with safe dependency and build fixes#116
Open
Riyasoni0 wants to merge 2 commits into
Open
Conversation
Riyasoni0
force-pushed
the
Fixing-vulnerabilities-for-npm-and-node
branch
from
9640a17 to
aa98699
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the fixes addressed vulnerabilities in both the backend and dashboard dependency trees.
In server/package.json, vulnerable packages like axios, body-parser, cookie-session, and http-proxy-middleware were upgraded to patched versions. This was required because Snyk was reporting critical/high issues such as prototype pollution, SSRF, HTTP response splitting, DoS, and unsafe request handling.
The biggest backend fix was removing kubernetes-client and moving to @kubernetes/client-node, with matching changes in server/k8s.js. This was required because the old Kubernetes client pulled in an outdated dependency chain with unpatched vulnerabilities like request, form-data, jsonpath-plus, tough-cookie, and uuid.
In dashboard/package.json, vulnerable frontend packages like axios, lodash, sass, and vuex-persist were upgraded. This was required to remove issues such as prototype pollution, recursion bugs, and vulnerable transitive dependencies.
Additional overrides were added in server/package.json and dashboard/package.json so transitive vulnerable packages like ajv, picomatch, underscore, form-data, and tough-cookie resolve to safer versions without broad app rewrites.