Conversation
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
r-devulap
requested changes
May 7, 2026
Contributor
r-devulap
left a comment
There was a problem hiding this comment.
Nice tutorial! It currently crashes and needs a small fix to create the directory ./local directory.
|
@ashkrisk @r-devulap one suggestion here, and feel free to tackle it separately off this PR. I wanted to run this, and compare the benefits of NVQ vs disk on the default dataset (ada-100k). A few things I felt could be added to the tutorial to make it more useful:
I made some of these changes, and could see the benefit of NVQ based compression vs the disk one (which doesn't use NVQ) from a storage size perspective.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds an example showing re-ranking using NVQ.