Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9430087
Fixed libuv1-dev issue
StuartWheater Apr 23, 2026
20c7c65
Merge pull request #667 from datashield/v6.3.6-dev_fix/libuv1
StuartWheater Apr 24, 2026
9258032
fix(glm): get family name from object (legacy dsBase) or from returne…
ymarcon Apr 22, 2026
e92a78d
Merge pull request #666 from datashield/fix/glm-family
ymarcon May 1, 2026
b219c03
Reworking Armadillo logging config
StuartWheater May 8, 2026
cd6346f
Updated 'hp-laptop' perf profile
StuartWheater May 8, 2026
dc9b3e0
Update dsBase tars and associated 'azure-pipelines'
StuartWheater May 8, 2026
61c7975
Update dsBase tars and associated files
StuartWheater May 8, 2026
a492c22
Merge branch 'v6.3.6-dev' of github.com:StuartWheater/dsBaseClient in…
StuartWheater May 8, 2026
cbef6da
Switch to Roxygen 8.0.0
StuartWheater May 12, 2026
4637d79
Fixed test which check class of family variable
StuartWheater May 12, 2026
d153176
Merge pull request #670 from datashield/v6.3.6-dev-fix/family-class
StuartWheater May 13, 2026
10fe92d
Merge branch 'datashield:v6.3.6-dev' into v6.3.6-dev
StuartWheater May 13, 2026
2cccc17
Merge pull request #669 from StuartWheater/v6.3.6-dev
StuartWheater May 13, 2026
1915a1f
Merge branch 'v6.3.6-dev' of github.com:StuartWheater/dsBaseClient in…
StuartWheater May 13, 2026
1dff161
Integration of STANDARDISE datasets
StuartWheater May 28, 2026
50a441b
Merge pull request #676 from StuartWheater/v6.3.6-dev
StuartWheater May 29, 2026
21e1e25
Merge branch 'v6.3.6-dev-feat/standardise-df' into Merge6.3.6_20260529
StuartWheater May 29, 2026
ab4f2c4
Update R version to '4.1.0' and added 'purrr' package
StuartWheater May 29, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
^R/secure.global.ranking.md$
^_pkgdown\.yml$
^docs$
^dsBase_6.3.5.tar.gz$
^dsBase_6.3.5-permissive.tar.gz$
^dsBase_6.3.6.tar.gz$
^dsBase_6.3.6-permissive.tar.gz$
^dsDanger_6.3.4.tar.gz$
^\.circleci$
^\.circleci/config\.yml$
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dsBaseClient_test_suite.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ jobs:
- name: Install dsBase to Armadillo
run: |
curl -u admin:admin -X GET http://localhost:8080/packages
curl -u admin:admin -H 'Content-Type: multipart/form-data' -F "file=@dsBase_6.3.5-permissive.tar.gz" -X POST http://localhost:8080/install-package
curl -u admin:admin -H 'Content-Type: multipart/form-data' -F "file=@dsBase_6.3.6-permissive.tar.gz" -X POST http://localhost:8080/install-package
sleep 60
docker restart dsbaseclient-armadillo-1
sleep 30
Expand Down
5 changes: 3 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Authors@R: c(person(given = "Paul",
comment = c(ORCID = "0009-0003-2419-1964")))
License: GPL-3
Depends:
R (>= 4.0.0),
R (>= 4.1.0),
DSI (>= 1.7.1)
Imports:
fields,
Expand All @@ -70,6 +70,7 @@ Imports:
data.table,
methods,
dplyr,
purrr,
assertthat,
cli
Suggests:
Expand All @@ -83,6 +84,6 @@ Suggests:
DSOpal,
DSMolgenisArmadillo,
DSLite
RoxygenNote: 7.3.3
Encoding: UTF-8
Language: en-GB
Config/roxygen2/version: 8.0.0
5 changes: 3 additions & 2 deletions R/ds.glm.R
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,8 @@ ds.glm <- function(formula=NULL, data=NULL, family=NULL, offset=NULL, weights=NU
# Sum participants only during first iteration.
nsubs.total<-Reduce(f="+", .select(study.summary, 'numsubs'))
# Save family
f <- study.summary[[1]]$family
family.value <- study.summary[[1]]$family
f <- if (is.list(family.value) && "family" %in% names(family.value)) family.value$family else family.value
}

#Create variance covariance matrix as inverse of information matrix
Expand Down Expand Up @@ -640,7 +641,7 @@ ds.glm <- function(formula=NULL, data=NULL, family=NULL, offset=NULL, weights=NU
beta.vect.final<-beta.vect.next

scale.par <- 1
if(f$family== 'gaussian') {
if(f == 'gaussian') {
scale.par <- dev.total / (nsubs.total-length(beta.vect.next))
}

Expand Down
8 changes: 4 additions & 4 deletions armadillo_azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ schedules:
- master
always: true
- cron: "0 2 * * *"
displayName: Nightly build - v6.3.5-dev
displayName: Nightly build - v6.3.6-dev
branches:
include:
- v6.3.5-dev
- v6.3.6-dev
always: true

#########################################################################################
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
sudo apt-get upgrade -y

sudo apt-get install -qq libxml2-dev libcurl4-openssl-dev libssl-dev libgsl-dev libgit2-dev r-base -y
sudo apt-get install -qq libharfbuzz-dev libfribidi-dev libmagick++-dev libudunits2-dev -y
sudo apt-get install -qq libharfbuzz-dev libfribidi-dev libmagick++-dev libudunits2-dev libuv1-dev -y
sudo R -q -e "install.packages(c('devtools','covr'), dependencies=TRUE, repos='https://cloud.r-project.org')"
sudo R -q -e "install.packages(c('fields','meta','metafor','ggplot2','gridExtra','data.table'), dependencies=TRUE, repos='https://cloud.r-project.org')"
sudo R -q -e "install.packages(c('DSI','DSOpal','DSLite'), dependencies=TRUE, repos='https://cloud.r-project.org')"
Expand Down Expand Up @@ -236,7 +236,7 @@ jobs:

curl -u admin:admin -X GET http://localhost:8080/packages

curl -u admin:admin --max-time 300 -v -H 'Content-Type: multipart/form-data' -F "file=@dsBase_6.3.5-permissive.tar.gz" -X POST http://localhost:8080/install-package
curl -u admin:admin --max-time 300 -v -H 'Content-Type: multipart/form-data' -F "file=@dsBase_6.3.6-permissive.tar.gz" -X POST http://localhost:8080/install-package
sleep 60

docker container restart dsbaseclient_armadillo_1
Expand Down
8 changes: 4 additions & 4 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ schedules:
- master
always: true
- cron: "0 2 * * *"
displayName: Nightly build - v6.3.5-dev
displayName: Nightly build - v6.3.6-dev
branches:
include:
- v6.3.5-dev
- v6.3.6-dev
always: true

#########################################################################################
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
sudo apt-get upgrade -y

sudo apt-get install -qq libxml2-dev libcurl4-openssl-dev libssl-dev libgsl-dev libgit2-dev r-base -y
sudo apt-get install -qq libharfbuzz-dev libfribidi-dev libmagick++-dev libudunits2-dev -y
sudo apt-get install -qq libharfbuzz-dev libfribidi-dev libmagick++-dev libudunits2-dev libuv1-dev -y
sudo R -q -e "install.packages(c('curl','httr'), dependencies=TRUE, repos='https://cloud.r-project.org')"
sudo R -q -e "install.packages(c('devtools','covr'), dependencies=TRUE, repos='https://cloud.r-project.org')"
sudo R -q -e "install.packages(c('fields','meta','metafor','ggplot2','gridExtra','data.table'), dependencies=TRUE, repos='https://cloud.r-project.org')"
Expand Down Expand Up @@ -217,7 +217,7 @@ jobs:
- bash: |
R -q -e "library(opalr); opal <- opal.login(username = 'administrator', password = 'datashield_test&', url = 'http://localhost:8080'); opal.put(opal, 'system', 'conf', 'general', '_rPackage'); opal.logout(opal)"

R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='http://localhost:8080/'); dsadmin.install_github_package(opal, 'dsBase', username = 'datashield', ref = 'v6.3.5-dev'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='http://localhost:8080/'); dsadmin.install_github_package(opal, 'dsBase', username = 'datashield', ref = 'v6.3.6-dev'); opal.logout(opal)"

sleep 60

Expand Down
Binary file not shown.
Binary file renamed dsBase_6.3.5.tar.gz → dsBase_6.3.6.tar.gz
Binary file not shown.
8 changes: 4 additions & 4 deletions opal_azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ schedules:
- master
always: true
- cron: "0 2 * * *"
displayName: Nightly build - v6.3.5-dev
displayName: Nightly build - v6.3.6-dev
branches:
include:
- v6.3.5-dev
- v6.3.6-dev
always: true

#########################################################################################
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
sudo apt-get upgrade -y

sudo apt-get install -qq libxml2-dev libcurl4-openssl-dev libssl-dev libgsl-dev libgit2-dev r-base -y
sudo apt-get install -qq libharfbuzz-dev libfribidi-dev libmagick++-dev libudunits2-dev -y
sudo apt-get install -qq libharfbuzz-dev libfribidi-dev libmagick++-dev libudunits2-dev libuv1-dev -y
sudo R -q -e "install.packages(c('curl','httr'), dependencies=TRUE, repos='https://cloud.r-project.org')"
sudo R -q -e "install.packages(c('devtools','covr'), dependencies=TRUE, repos='https://cloud.r-project.org')"
sudo R -q -e "install.packages(c('fields','meta','metafor','ggplot2','gridExtra','data.table'), dependencies=TRUE, repos='https://cloud.r-project.org')"
Expand Down Expand Up @@ -217,7 +217,7 @@ jobs:
- bash: |
R -q -e "library(opalr); opal <- opal.login(username = 'administrator', password = 'datashield_test&', url = 'http://localhost:8080'); opal.put(opal, 'system', 'conf', 'general', '_rPackage'); opal.logout(opal)"

R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='http://localhost:8080/'); dsadmin.install_github_package(opal, 'dsBase', username = 'datashield', ref = 'v6.3.5-dev'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='http://localhost:8080/'); dsadmin.install_github_package(opal, 'dsBase', username = 'datashield', ref = 'v6.3.6-dev'); opal.logout(opal)"

sleep 60

Expand Down
11 changes: 8 additions & 3 deletions tests/docker/armadillo/standard/config/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,13 @@ stdout.log.path: '/logs/armadillo.log'

logging:
level:
root: INFO
root: "warn"
## change to DEBUG to have more details, typically when developing
org.molgenis: INFO
org.molgenis: "warn"
## Don't log upload data
org.apache.coyote.http11.Http11InputBuffer: INFO
org.apache.coyote.http11.Http11InputBuffer: "warn"
## SpringFramework
org.springframework.boot: "warn"
org.springframework.web: "warn"
org.springframework.core: "warn"
org.springframework.codex: "warn"
61 changes: 61 additions & 0 deletions tests/testthat/connection_to_datasets/init_studies_datasets.R
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,62 @@ init.studies.dataset.gamlss <- function(variables)
}
}

init.studies.dataset.stand <- function(variables)
{
if (ds.test_env$secure_login_details)
{
if (ds.test_env$driver == "OpalDriver")
{
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
builder$append(server = "sim1", url = ds.test_env$ip_address_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "STANDARDISE.std_1", options=ds.test_env$options_1)
builder$append(server = "sim2", url = ds.test_env$ip_address_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "STANDARDISE.std_1", options=ds.test_env$options_2)
builder$append(server = "sim3", url = ds.test_env$ip_address_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "STANDARDISE.std_1", options=ds.test_env$options_3)
ds.test_env$login.data <- builder$build()
}
else if (ds.test_env$driver == "ArmadilloDriver")
{
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
builder$append(server = "sim1", url = ds.test_env$ip_address_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "datashield/standardise/std_1", driver = ds.test_env$driver)
builder$append(server = "sim2", url = ds.test_env$ip_address_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "datashield/standardise/std_2", driver = ds.test_env$driver)
builder$append(server = "sim3", url = ds.test_env$ip_address_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "datashield/standardise/std_3", driver = ds.test_env$driver)
ds.test_env$login.data <- builder$build()
}
else
{
ds.test_env$login.data <- DSLite::setupCNSIMTest("dsBase", env = ds.test_env)
}
ds.test_env$stats.var <- variables
}
}

init.studies.dataset.stand_disclosure <- function(variables)
{
if (ds.test_env$secure_login_details)
{
if (ds.test_env$driver == "OpalDriver")
{
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
builder$append(server = "sim1", url = ds.test_env$ip_address_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "STANDARDISE.std_1_d", options=ds.test_env$options_1)
builder$append(server = "sim2", url = ds.test_env$ip_address_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "STANDARDISE.std_2_d", options=ds.test_env$options_2)
builder$append(server = "sim3", url = ds.test_env$ip_address_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "STANDARDISE.std_3_d", options=ds.test_env$options_3)
ds.test_env$login.data <- builder$build()
}
else if (ds.test_env$driver == "ArmadilloDriver")
{
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
builder$append(server = "sim1", url = ds.test_env$ip_address_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "datashield/standardise/std_1_d", driver = ds.test_env$driver)
builder$append(server = "sim2", url = ds.test_env$ip_address_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "datashield/standardise/std_2_d", driver = ds.test_env$driver)
builder$append(server = "sim3", url = ds.test_env$ip_address_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "datashield/standardise/std_3_d", driver = ds.test_env$driver)
ds.test_env$login.data <- builder$build()
}
else
{
ds.test_env$login.data <- DSLite::setupCNSIMTest("dsBase", env = ds.test_env)
}
ds.test_env$stats.var <- variables
}
}


init.studies.dataset.stand <- function(variables)
{
Expand Down Expand Up @@ -390,3 +446,8 @@ disconnect.studies.dataset.stand <- function()
{
log.out.data.server()
}

disconnect.studies.dataset.stand_disclosure <- function()
{
log.out.data.server()
}
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,12 @@ upload_testing_dataset_table(opal, 'TESTING', 'DATASET1', 'TESTING/DATASET1.rda'
upload_testing_dataset_table(opal, 'TESTING', 'DATASET2', 'TESTING/DATASET2.rda')
upload_testing_dataset_table(opal, 'TESTING', 'DATASET3', 'TESTING/DATASET3.rda')

upload_testing_dataset_table(opal, 'STANDARDISE', 'std_1', 'STANDARDISE/std_1.rda')
upload_testing_dataset_table(opal, 'STANDARDISE', 'std_2', 'STANDARDISE/std_2.rda')
upload_testing_dataset_table(opal, 'STANDARDISE', 'std_3', 'STANDARDISE/std_3.rda')

upload_testing_dataset_table(opal, 'STANDARDISE', 'std_1_d', 'STANDARDISE/std_1_d.rda')
upload_testing_dataset_table(opal, 'STANDARDISE', 'std_2_d', 'STANDARDISE/std_2_d.rda')
upload_testing_dataset_table(opal, 'STANDARDISE', 'std_3_d', 'STANDARDISE/std_3_d.rda')

opal.logout(opal)
26 changes: 13 additions & 13 deletions tests/testthat/perf_files/armadillo_hp-laptop-quay_perf-profile.csv
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
"refer_name","rate","lower_tolerance","upper_tolerance"
"conndisconn::perf::simple0","0.04918","0.5","2"
"ds.abs::perf::0","1.184","0.5","2"
"ds.asInteger::perf:0","1.297","0.5","2"
"ds.asList::perf:0","2.884","0.5","2"
"ds.asNumeric::perf:0","1.354","0.5","2"
"ds.assign::perf::0","2.745","0.5","2"
"ds.class::perf::combine:0","3.261","0.5","2"
"ds.colnames::perf:0","8.566","0.5","2"
"ds.exists::perf::combine:0","6.342","0.5","2"
"ds.length::perf::combine:0","7.835","0.5","2"
"ds.mean::perf::combine:0","8.127","0.5","2"
"ds.mean::perf::split:0","8.109","0.5","2"
"void::perf::void::0","20280.0","0.5","2"
"conndisconn::perf::simple0","0.06790","0.5","2"
"ds.abs::perf::0","1.998","0.5","2"
"ds.asInteger::perf:0","2.111","0.5","2"
"ds.asList::perf:0","4.550","0.5","2"
"ds.asNumeric::perf:0","1.879","0.5","2"
"ds.assign::perf::0","4.806","0.5","2"
"ds.class::perf::combine:0","3.865","0.5","2"
"ds.colnames::perf:0","9.577","0.5","2"
"ds.exists::perf::combine:0","8.411","0.5","2"
"ds.length::perf::combine:0","7.957","0.5","2"
"ds.mean::perf::combine:0","9.049","0.5","2"
"ds.mean::perf::split:0","9.429","0.5","2"
"void::perf::void::0","21400.0","0.5","2"
4 changes: 2 additions & 2 deletions tests/testthat/test-smk-ds.elspline.R
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ test_that("elspline", {
expect_equal(res.mod$errorMessage[3], "No errors")
expect_equal(res.mod$nsubs, 7477)
expect_equal(res.mod$iter, 3)
expect_true("family" %in% class(res.mod$family))
expect_true("character" %in% class(res.mod$family))
expect_equal(res.mod$formula, "D$LAB_TRIG ~ elsplineDS")
expect_true("matrix" %in% class(res.mod$coefficients))
expect_true("array" %in% class(res.mod$coefficients))
Expand Down Expand Up @@ -106,7 +106,7 @@ test_that("elspline", {
expect_equal(res.mod$errorMessage[3], "No errors")
expect_equal(res.mod$nsubs, 7477)
expect_equal(res.mod$iter, 3)
expect_true("family" %in% class(res.mod$family))
expect_true("character" %in% class(res.mod$family))
expect_equal(res.mod$formula, "D$LAB_TRIG ~ elsplineDS2")
expect_true("matrix" %in% class(res.mod$coefficients))
expect_true("array" %in% class(res.mod$coefficients))
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test-smk-ds.glm-binomial.R
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ test_that("glm_binomial", {
expect_equal(res$errorMessage[3], "No errors")
expect_equal(res$nsubs, 7485)
expect_equal(res$iter, 9)
expect_true("family" %in% class(res$family))
expect_true("character" %in% class(res$family))
expect_equal(res$formula, "D$DIS_DIAB ~ D$GENDER * D$PM_BMI_CONTINUOUS + D$LAB_HDL")
expect_true("matrix" %in% class(res$coefficients))
expect_equal(res$dev, 1036.031, tolerance=0.00001)
Expand All @@ -69,7 +69,7 @@ test_that("glm_binomial, with check", {
expect_equal(res$errorMessage[3], "No errors")
expect_equal(res$nsubs, 7485)
expect_equal(res$iter, 9)
expect_true("family" %in% class(res$family))
expect_true("character" %in% class(res$family))
expect_equal(res$formula, "D$DIS_DIAB ~ D$GENDER * D$PM_BMI_CONTINUOUS + D$LAB_HDL")
expect_true("matrix" %in% class(res$coefficients))
expect_equal(res$dev, 1036.031, tolerance=0.00001)
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test-smk-ds.glm-gaussian.R
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ test_that("glm_gaussian", {
expect_equal(res$errorMessage[3], "No errors")
expect_equal(res$nsubs, 7800)
expect_equal(res$iter, 3)
expect_true("family" %in% class(res$family))
expect_true("character" %in% class(res$family))
expect_equal(res$formula, "D$LAB_TSC ~ D$LAB_TRIG")
expect_true("matrix" %in% class(res$coefficients))
expect_equal(res$dev, 8936.32, tolerance=0.00001)
Expand All @@ -69,7 +69,7 @@ test_that("glm_gaussian, with check", {
expect_equal(res$errorMessage[3], "No errors")
expect_equal(res$nsubs, 7800)
expect_equal(res$iter, 3)
expect_true("family" %in% class(res$family))
expect_true("character" %in% class(res$family))
expect_equal(res$formula, "D$LAB_TSC ~ D$LAB_TRIG")
expect_true("matrix" %in% class(res$coefficients))
expect_equal(res$dev, 8936.32, tolerance=0.00001)
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test-smk-ds.glm-poisson.R
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ test_that("glm_gaussian", {
expect_equal(res$errorMessage[3], "No errors")
expect_equal(res$nsubs, 6299)
expect_equal(res$iter, 5)
expect_true("family" %in% class(res$family))
expect_true("character" %in% class(res$family))
expect_equal(res$formula, "D$survtime ~ 1 + D$time.id + D$female")
expect_true("matrix" %in% class(res$coefficients))
expect_equal(res$dev, 3522.598, tolerance=0.00001)
Expand All @@ -69,7 +69,7 @@ test_that("glm_gaussian, which check", {
expect_equal(res$errorMessage[3], "No errors")
expect_equal(res$nsubs, 6299)
expect_equal(res$iter, 5)
expect_true("family" %in% class(res$family))
expect_true("character" %in% class(res$family))
expect_equal(res$formula, "D$survtime ~ 1 + D$time.id + D$female")
expect_true("matrix" %in% class(res$coefficients))
expect_equal(res$dev, 3522.598, tolerance=0.00001)
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-smk-ds.lspline.R
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ test_that("lspline", {
expect_equal(res.mod$errorMessage[3], "No errors")
expect_equal(res.mod$nsubs, 7477)
expect_equal(res.mod$iter, 3)
expect_true("family" %in% class(res.mod$family))
expect_true("character" %in% class(res.mod$family))
expect_equal(res.mod$formula, "D$LAB_TRIG ~ lsplineDS")
expect_true("matrix" %in% class(res.mod$coefficients))
expect_true("array" %in% class(res.mod$coefficients))
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-smk-ds.ns.R
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ test_that("ns", {
expect_equal(res.mod$errorMessage[3], "No errors")
expect_equal(res.mod$nsubs, 7477)
expect_equal(res.mod$iter, 3)
expect_true("family" %in% class(res.mod$family))
expect_true("character" %in% class(res.mod$family))
expect_equal(res.mod$formula, "D$LAB_TRIG ~ nsDS")
expect_true("matrix" %in% class(res.mod$coefficients))
expect_true("array" %in% class(res.mod$coefficients))
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test-smk-ds.qlspline.R
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ test_that("qlspline", {
expect_equal(res.mod$errorMessage[3], "No errors")
expect_equal(res.mod$nsubs, 7477)
expect_equal(res.mod$iter, 3)
expect_true("family" %in% class(res.mod$family))
expect_true("character" %in% class(res.mod$family))
expect_equal(res.mod$formula, "D$LAB_TRIG ~ qlsplineDS")
expect_true("matrix" %in% class(res.mod$coefficients))
expect_true("array" %in% class(res.mod$coefficients))
Expand Down Expand Up @@ -108,7 +108,7 @@ test_that("qlspline", {
expect_equal(res.mod$errorMessage[3], "No errors")
expect_equal(res.mod$nsubs, 7477)
expect_equal(res.mod$iter, 3)
expect_true("family" %in% class(res.mod$family))
expect_true("character" %in% class(res.mod$family))
expect_equal(res.mod$formula, "D$LAB_TRIG ~ qlsplineDS2")
expect_true("matrix" %in% class(res.mod$coefficients))
expect_true("array" %in% class(res.mod$coefficients))
Expand Down