Wires module update workflow for external repo callers.#20
Merged
Conversation
Contributor
|
Resolve conflicts, address code QL security alert comment, and add link to the repo you've tested this on. |
…aller working dir
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
b895442 to
e216094
Compare
ColinDaglish
reviewed
Jun 4, 2026
ColinDaglish
reviewed
Jun 4, 2026
ColinDaglish
reviewed
Jun 4, 2026
ColinDaglish
reviewed
Jun 4, 2026
ColinDaglish
reviewed
Jun 4, 2026
ColinDaglish
reviewed
Jun 4, 2026
ColinDaglish
reviewed
Jun 4, 2026
Contributor
|
Getting this error on the caller repo: |
ColinDaglish
reviewed
Jun 4, 2026
ColinDaglish
requested changes
Jun 4, 2026
Contributor
ColinDaglish
left a comment
There was a problem hiding this comment.
Looking really good. On the whole I think this is nearly there.
Required
- Fix versions to commit SHA's for mutability
- Need to see working example
Optional
- Consider hard coding values which won't change (e.g updater_repository)
- Consider splitting readme into single purpose driven docs (contributing guidance, variable reference guide, etc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the reusable Terraform module update workflow for external repository callers, adds contract validation, and expands consumer-facing documentation so downstream teams can adopt this tool reliably.
Context
No linked ticket. This branch (
add-workflow-wiring) has been tested via a call from an external repository and is ready to merge.Changes
update-tf-modules.ymlto support cross-repoworkflow_callwith configurable inputs, outputs (changed,pr_number,pr_url), and PR flow controlstest-reusable-workflow-contract.yml) that asserts output shape and enforcescreate_pr=falsebehaviour on each PR to mainexample-manifest.yml,examples/update-modules-manifest.example.yml) as a quick-start reference for consumersconfig.pyto ensure the package install location is correct when called from a workflowTesting
changedis alwaystrue/falseand thatpr_number/pr_urlare empty whencreate_pr=falseRisks / Notes
updater_refdefaults toadd-workflow-wiringand should be updated tomain(or a version tag) post-mergeNext steps