Serve VERSION_D at /static/VERSION_D — add static-files build asset (#813) - #1474
Closed
Kasinhou wants to merge 2 commits into
Closed
Serve VERSION_D at /static/VERSION_D — add static-files build asset (#813)#1474Kasinhou wants to merge 2 commits into
Kasinhou wants to merge 2 commits into
Conversation
…813) The static-page module and sourceversion.py/docker.yml were already present on this branch, but `src/static-files` was not registered as a build asset, so the CI-generated src/static-files/VERSION_D.html was never deployed and `/static/VERSION_D` returned nothing. Add `src/static-files` to angular.json assets to match dtq-dev, making the deployed-commit info reachable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Only the deployed-version info page should be reachable. Scope the angular.json asset to VERSION_D.html and remove the inherited LINDAT static-files set (about/cite/faq/license pages + cs/ localized copies) so nothing else under /static is web-accessible. A VERSION_D.html placeholder keeps the directory present for the build-time generation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why (issue #813)
Every customer should be able to see which commit is currently deployed. On the reference branch
dtq-devthis is served at/static/VERSION_D.This branch already had the static-page module,
scripts/sourceversion.pyand thedocker.ymlstep that generatessrc/static-files/VERSION_D.htmlat build time — butsrc/static-fileswas not registered as a build asset inangular.json, so the generated file was never deployed and/static/VERSION_Dreturned nothing.Change
angular.json: addsrc/static-filesto the buildassets(matchesdtq-dev).One line. No runtime/behaviour change beyond making the version file reachable.
Verification
ng buildproducesdist/browser/static-files/VERSION_D.html./static/VERSION_Drenders the git hash, commit date and build-run link.🤖 Generated with Claude Code