DSpace9/Redirect back to originating page after DiscoJuice local login

[Kasinhou]

Problem

On CLARIN DSpace v9, logging in from a non-home page through the DiscoJuice local authentication flow always redirected the user to the home page instead of back to the page they started from. The dspace-ui-tests scenario LINDAT-013 (loginPage.spec.ts → login from search page should redirect back to search page) failed because of this.

Root cause

The DiscoJuice local-auth handler (src/aai/aai.js) sends the user to /login?redirectUrl=<absolute page URL>. On the standalone login page, LogInPasswordComponent.submit() ignored that query param and always called setRedirectUrlIfNotSet('/'), so the stored post-login target was the home page. (The value travels through the URL on purpose — it is lost from the auth store while passing through DiscoJuice.)

Fix

On the standalone login page, LogInPasswordComponent now reads the redirectUrl query param and:

• reduces it to an app-relative path (/repository/search) — the same format HardRedirectService.getCurrentRoute() produces and that the existing reloadGuard already consumes;
• prefers a nested redirectUrl (login initiated from the login page) so we never redirect back to /login;
• falls back to the previous setRedirectUrlIfNotSet('/') when no redirectUrl is present.

Mirrors the verified dtq-dev fix 9dff6af543, adapted to the refactored v9 component (v9 uses HardRedirectService instead of the v7 baseUrl/config lookup).

Implementation notes

Kept the code comments terse; the detail lives here.

• getRedirectUrlFromQueryParams() reads route.snapshot.queryParams.redirectUrl. aai.js appends it as the absolute page URL (e.g. http://host/repository/search) — the value is dropped from the auth store while passing through DiscoJuice, so it has to be read back from the URL.
• If that value itself carries a nested ?redirectUrl=… (login started while already on /login), the inner target is preferred so we never redirect back to /login.
• toRelativePath() drops the scheme+host with a string .replace(/^https?:\/\/[^/]+/i, '') (http://host/repository/search → /repository/search); already-relative values pass through unchanged. This is the same string-replace technique v7 uses (redirectUrl.replace(baseUrl, '')) — but host-agnostic, so it cannot throw and is unaffected by a misconfigured ui.baseUrl. The result matches the format HardRedirectService.getCurrentRoute() produces, which reloadGuard then strips to the app route.
• Query params are untyped: getRedirectUrlFromQueryParams() returns string | null and falls back to the default redirect for a missing or non-string (string[]) redirectUrl, so login submission can never break on a malformed value.

Scope

Covers LINDAT-013 (login initiated from a public page, where aai.js puts the target in the URL). It does not port dtq-dev's ngOnInit → setUpRedirectUrl() re-navigation, which additionally covers the guard-initiated flow (e.g. a restricted collection bounces to /login with the target only in the store) through DiscoJuice. No test covers that flow; can be added on request.

Tests

Added unit tests to log-in-password.component.spec.ts covering the relative-path reduction, query-string preservation, nested-redirectUrl handling, and the no-param fallback. ng test for this spec passes.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes CLARIN DSpace v9 standalone DiscoJuice local-auth login flow so users are redirected back to the originating page (via redirectUrl query param) instead of always landing on the home page, unblocking dspace-ui-tests scenario LINDAT-013.

Changes:

• Read redirectUrl from the standalone login page query params and store it as the post-login redirect target.
• Normalize absolute URLs to app-relative paths and prefer nested redirectUrl to avoid redirecting back to /login.
• Add unit tests covering the new redirect behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/app/shared/log-in/methods/password/log-in-password.component.ts	Read and normalize redirectUrl query param for standalone login redirects.
src/app/shared/log-in/methods/password/log-in-password.component.spec.ts	Adds unit tests validating standalone-login redirect behavior.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.