Start-DbaMigration: Enhance handling of dedicated admin connections

[andreasjordan]

Type of Change

• Bug fix (non-breaking change, fixes # )
• New feature (non-breaking change, adds functionality, fixes # )
• Breaking change (affects multiple commands or functionality, fixes # )
• Ran manual Pester test and has passed (Invoke-ManualPester)
• Adding code coverage to existing functionality
• Pester test is included
• If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
• Unit test is included
• Documentation
• Build system

When opening a connection we test if we need a DAC and we test if we already have a DAC. We reuse a DAC when possible. We remember if we opened a DAC to later be able to close it.

Get-DecryptedObject needs two things:

• A Dedicated Admin Connection (DAC) to select master.sys.syslnklgns
• A WinRM connection to read "HKLM:\SOFTWARE\Microsoft\Microsoft SQL Server$serviceInstanceId\Security"

That's why Get-DecryptedObject needs $Credential which it used all the time, but the parameter was missing. So every command that calls Get-DecryptedObject needs $Credential as well. And every command that calls one of those commands as well.

[andreasjordan]

Test "Run Cross Platform Tests / linux-tests (ubuntu-latest) (push)" fails with:

[andreasjordan]

I think we now open a DAC connection instead of a normal connection based on the parameters for Start-DbaMigration. Maybe adding "ADMIN:" to what is currently used fails.

[andreasjordan]

Let's exclude "DatabaseMail" as well on github action, so that no dac is needed.

[potatoqualitee]

This looks pretty standard of a change but i need a non-morning brain to comprehend a little better before merging

[andreasjordan]

No problem. Thanks for merging all the others - now I can work on the last round of fixes for the DAC.

[potatoqualitee]

Looks good! 🤩