Improve tests to be more flexible #10096
Merged
+23
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ohhh nice change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed these tests to be able to target different sql server versions and instance configurations.
Test-DbaConnection.Tests.ps1:
This test used a fixed port 1433, now gets the used port first.
Test-DbaDiskAlignment.Tests.ps1:
This test was the only test that used "$TestConfig.DbaToolsCi_Computer" and was run in the default scenario. The test now uses the computer of $TestConfig.instance1 and runs in that scenario. This way the default scenario only included tests that do not need a running instance.
Test-DbaLinkedServerConnection.Tests.ps1:
This test used a fixed port 1433, now uses the complete instance name as the target. So this test can run against every instance. For AppVeyor the test still has to use the old SQLNCLI11 instead of the MSOLEDBSQL provider as that one is not installed.