Skip to content
This repository was archived by the owner on Apr 17, 2018. It is now read-only.

Switch default values to UTC, and add sub-second values#80

Open
tpitale wants to merge 3 commits into
datamapper:masterfrom
tpitale:support-utc-tz
Open

Switch default values to UTC, and add sub-second values#80
tpitale wants to merge 3 commits into
datamapper:masterfrom
tpitale:support-utc-tz

Conversation

@tpitale

@tpitale tpitale commented Mar 11, 2015

Copy link
Copy Markdown
Member

First pass, we probably need more specs in different timezones, and more structure between Time and DateTime.

Please let me know what you think @dbussink. This is passing when I run bundle exec rake spec from within do_postgres.

@tpitale

tpitale commented Mar 11, 2015

Copy link
Copy Markdown
Member Author

This relates to both #78 and #79.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this local call doesn't support setting the timezone AFAIK.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we'd need to handle the cases different here then. Use local when there's no UTC offset present, but build an object with the specific UTC offset otherwise.

@tpitale

tpitale commented Mar 13, 2015

Copy link
Copy Markdown
Member Author

Hrm. TravisCI appears to be randomly killing the build after that last push.

@dbussink

Copy link
Copy Markdown
Contributor

@tpitale What do you mean with killing the build?

@tpitale

tpitale commented Mar 13, 2015

Copy link
Copy Markdown
Member Author

The builds stopped at random places, and the last thing in the log is: 'The build has been terminated'. https://travis-ci.org/datamapper/do/jobs/54308706#L573

@dbussink

Copy link
Copy Markdown
Contributor

@tpitale I suspect something might be broken then that causes it to hang indefinitely and then Travis aborts it. I suspect it's a problem with the changes, not with Travis. Might have some time tomorrow to run this and see if there's anything standing out.

@tpitale

tpitale commented Mar 13, 2015

Copy link
Copy Markdown
Member Author

Yeah, the specs stalled for me locally after that change. I'll dig in when I get home tonight. I had to reinstall my MySQL.

@tpitale

tpitale commented Mar 14, 2015

Copy link
Copy Markdown
Member Author

Okay, I reverted that change from yesterday. Now I'm trying to figure out how to get mysql to work in UTC. It's just insanity.

@tpitale

tpitale commented Mar 14, 2015

Copy link
Copy Markdown
Member Author

I don't think it's possible for mysql to share specs with postgresql and use a time zone other than local system time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants