Repository navigation
1.11.1: a foreign image holds the working directory its base's doctor checks - #42
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the foreign-image content-directory fix.
No open issues 🎉
What changed in this PR
Fixes foreign-image builds by creating /home/datalayer/content before assigning ownership, so doctor checks copied from the approved base can find the expected working directory.
Changes:
- Creates the content directory alongside the Jupyter runtime directory before
chown. - Adds a regression test checking that directory creation precedes ownership assignment.
- Bumps the package version to
1.11.1.
| File | Description |
|---|---|
tests/test_environment_foreign_contract_layer.py |
Tests that the content directory is included before chown. |
code_sandboxes/environments/adapters/datalayer.py |
Creates the content directory in the foreign-image contract layer. |
code_sandboxes/__version__.py |
Updates the version to 1.11.1. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A foreign image's build copies
datalayer-sandboxfrom the approved base, and the 2026.09 channel's doctor checks/home/datalayer/content. Docker'sWORKDIRnever created it for the contract's user, so a build ofpython:3.12-slimfailed its last step withworkdir failed: /home/datalayer/content is missing or not writable. The contract layer now creates it before thechown.