chore: remove .vscode and .devcontainer#1459
Open
dimitri-yatsenko wants to merge 1 commit into
Open
Conversation
Neither directory plays any role in the published package, CI tests, or release path. The .devcontainer/Dockerfile had drifted from current tooling (still installing nose/nose-cov), and pixi already provides a reproducible dev env. Also drops the now-dead check-json exclude in .pre-commit-config.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.vscode/(launch.json, settings.json) and.devcontainer/(devcontainer.json, docker-compose.yml, Dockerfile).check-jsonexclude in.pre-commit-config.yaml(the only JSON-with-//-comments files lived in those two directories).Why
Neither directory is part of the published wheel/sdist (
pyproject.tomlships onlysrc/datajoint), neither is referenced by CI (tests use testcontainers; thedjtestprofile uses the rootDockerfile), and.devcontainer/Dockerfilehad drifted from current tooling (still installingnose/nose-cov). Pixi already provides a reproducible dev environment, so contributors keep a working path.Test plan
pip install -e ".[test]"succeedspytest tests/passes (testcontainers-backed, independent of.devcontainer/)docker compose --profile test up djtest --buildpasses (rootDockerfile)pre-commit run --all-filespassesgrep -rn "vscode\|devcontainer" --exclude-dir=.gitreturns nothing