Skip to content

Conversation

@gabotechs
Copy link
Collaborator

I'm finding a bit hard to deal with the TPCH tests as they currently are:

  • Sometimes, I want to just see what's the plan, and for that, I'm fine with a very low TPCH scale, and I'm fine not even executing the queries
  • Sometimes, I want to ensure correctness with a very big TPCH scale, and for that I want to greatly increase the TPCH scale, and I don't want to be dealing with plans

This PR splits the TPCH tests in 3:

  • plan tests: the queries get just planned, but they do not run. It's fine that there's a very small TPCH SF.
  • correctness tests: no plan is compared, just the actual results between single node vs distributed.
  • explain analyze tests: the plans with metrics are asserted, but it's fine if there's a small TPCH SF.

@gabotechs gabotechs force-pushed the gabrielmusat/split-up-tpch-tests branch from 8632e38 to c3181a6 Compare November 20, 2025 11:03
@gabotechs gabotechs merged commit a8952c7 into main Nov 21, 2025
4 checks passed
@gabotechs gabotechs deleted the gabrielmusat/split-up-tpch-tests branch November 21, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants