Skip to content

add tpc-ds tests and property-based testing utilities #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add tpc-ds tests and property-based testing utilities #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8105871
add tpc-ds tests and property-based testing utilities
jayshrivastava Nov 17, 2025
839fdc2
add tpcds-randomized-test to ci
jayshrivastava Nov 20, 2025
95320e6
Remove unnecessary traits
gabotechs Nov 21, 2025
5f31b16
refactor based on PR comments
jayshrivastava Nov 21, 2025
67ce84c
update ci
jayshrivastava Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@ runs:
- uses: Swatinem/rust-cache@v2
with:
key: ${{ runner.os }}-${{ inputs.targets }}-rust-cache
prefix-key: v1-rust
18 changes: 18 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:
env:
CARGO_TERM_COLOR: always
RUST_BACKTRACE: 1
TPCDS_SCALE_FACTOR: 0.5 # 0.5 scale factor produces a data dir which is 124MB

concurrency:
group: ${{ github.ref }}
Expand Down Expand Up @@ -40,6 +41,23 @@ jobs:
- uses: ./.github/actions/setup
- run: cargo test --features tpch --test 'tpch_*'

tpcds-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
lfs: true
- uses: ./.github/actions/setup
- name: Install DuckDB CLI
run: |
curl https://install.duckdb.org | sh
mkdir -p $HOME/.local/bin
mv /home/runner/.duckdb/cli/latest/duckdb $HOME/.local/bin/
echo "$HOME/.local/bin" >> $GITHUB_PATH
Comment on lines +52 to +56
Copy link
Collaborator

@gabotechs gabotechs Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it not sufficient to just do:

curl https://install.duckdb.org | sh

I imagine that will already install the cli in the appropriate place accessible from $PATH

Copy link
Collaborator Author

@jayshrivastava jayshrivastava Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the script, it does not add /home/runner/.duckdb/cli/latest/duckdb to the $PATH.

- name: Run TPC-DS test
id: test
run: cargo test --features tpcds --test tpcds_test

format-check:
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
/benchmarks/data/
testdata/tpch/*
!testdata/tpch/queries
testdata/tpch/data/
testdata/tpcds/data/
Loading
Loading