-
Notifications
You must be signed in to change notification settings - Fork 226
Add Bluey provider with characters, quotes and locations #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bluey provider with characters, quotes and locations #1740
Conversation
PR Summary
|
|
Build is failing, likely needs a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new Bluey provider to the DataFaker library, enabling generation of fake data related to the Bluey animated television series. The implementation follows the established pattern for entertainment providers.
Key Changes
- New Bluey provider class with methods to generate character names, locations, and quotes
- YAML data file containing Bluey-related data (9 characters, 4 locations, 5 quotes)
- Test class following the standard entertainment provider test pattern
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/net/datafaker/providers/entertainment/Bluey.java | New provider class with character(), location(), and quote() methods |
| src/main/resources/en/bluey.yml | Data file containing characters, locations, and quotes from the Bluey series |
| src/test/java/net/datafaker/providers/entertainment/BlueyTest.java | Test class validating the provider methods against YAML keys |
| src/main/java/net/datafaker/providers/entertainment/EntertainmentProviders.java | Registration of the Bluey provider in the entertainment providers interface |
kingthorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line added in EnFile is missing a trailing comma
|
Oops... you are right... I missed. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1740 +/- ##
============================================
- Coverage 92.40% 92.32% -0.09%
- Complexity 3437 3439 +2
============================================
Files 337 338 +1
Lines 6779 6785 +6
Branches 670 670
============================================
Hits 6264 6264
- Misses 352 355 +3
- Partials 163 166 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi!!! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
I just did it. Assuming the build passes I'll merge it later today. |
No description provided.