Match macOS chrome and branding to dark mode - #15
Merged
Conversation
wisdomqin
force-pushed
the
agent/dark-mode-titlebar-logo
branch
from
August 14, 2026 08:14
8cb7ac6 to
001be99
Compare
# Conflicts: # test/branding-patch.test.ts
wisdomqin
marked this pull request as ready for review
August 14, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
body[data-ds-dark-theme]state so branding updates immediately without restartingWhy
Harness controls its own appearance independently from the macOS system theme. A one-time startup check left the sidebar logo stale after changing appearance, while allowing the native chrome to follow the page could turn the traffic-light strip white.
The desktop shell now separates these responsibilities: native macOS chrome remains dark, while the sidebar reads Harness's own resolved theme state directly. No duplicate color sampling or page-level theme observer can override the logo.
User impact
Validation
npm run typechecknpm test(40 tests)npm run buildgit diff --check