Skip to content

fix(models): preserve parameter deletions when switching models - #1412

Merged
ulleo merged 1 commit into
dataease:mainfrom
borealisalastor-byte:codex/fix-model-parameter-deletion
Oct 26, 2026
Merged

ulleo merged 1 commit into
dataease:mainfrom
borealisalastor-byte:codex/fix-model-parameter-deletion

Conversation

@borealisalastor-byte

Copy link
Copy Markdown
Contributor

Deleting an advanced parameter updates the visible list but leaves the per-model cache unchanged. Switching to another base model and back therefore restores the deleted parameter.

Update the current supplier/model cache after deletion, matching the existing add/edit handlers. The empty list is cached too, so deleting every parameter stays effective after switching back.

Fixes #1411.

Validation:

  • Added two regression tests that execute the component's actual handlers with Vue reactivity. Both fail on the original code and pass after the fix; they cover deleting one/all parameters, model/supplier isolation, and the emitted submission payload.
  • 29 relevant tests passed: test_model_parameter_cache, test_execution_error_details, and test_supplier_config.
  • Targeted ESLint, Ruff check/format, and npm run build passed.
  • Chrome verification using the real Vue form in an isolated local fixture reproduced the original bug. After the fix, deleting one/all parameters survives a model round trip and produces the expected submission payload.

No backend persistence, external LLM, or full deployment validation was performed.

@ulleo
ulleo merged commit 6d8081d into dataease:main Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Deleted model parameters reappear after switching base models

2 participants