Skip to content

[oncall cleanup] Disable periodic Node.js query testing - #6567

Open
n-h-diaz wants to merge 5 commits into
datacommonsorg:masterfrom
n-h-diaz:disable-nodejs-query
Open

[oncall cleanup] Disable periodic Node.js query testing#6567
n-h-diaz wants to merge 5 commits into
datacommonsorg:masterfrom
n-h-diaz:disable-nodejs-query

Conversation

@n-h-diaz

@n-h-diaz n-h-diaz commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Turn down periodic Node.js query testing across automated builds

Description

This change introduces an explicit toggle (enableNodejs: false) to disable periodic Node.js query tests in automated GKE cron executions by default. This reduces automated test churn and email alert noise from datacommons-alerts+tests@google.com while the Node.js server is scheduled for future deprecation. Manual testing remains fully supported via existing CLI scripts or by toggling the flag.

Changes

  • Add enableNodejs: false to default Helm configuration in values.yaml and explicitly under cronTesting in autopush.yaml.
  • Expose enableNodejs in the cron-testing-config Kubernetes ConfigMap and wire the ENABLE_NODEJS environment variable into the GKE CronJob template.
  • Update run_website_cron_tests.sh to check ENABLE_NODEJS == "true" before running query tests and differ notifications.
  • Update documentation in gke/README.md and tools/nl/nodejs_query_differ/README.md explaining the test toggle and deprecation status.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a mechanism to disable periodic Node.js query tests in automated GKE cron executions. By adding an explicit configuration toggle, the change aims to reduce test churn and alert noise while the Node.js server is being prepared for deprecation. Manual testing remains fully supported via existing workflows.

Highlights

  • Test Toggle Implementation: Introduced an enableNodejs flag to control the execution of periodic Node.js query tests in automated GKE cron jobs.
  • Configuration Updates: Updated Helm charts and Kubernetes ConfigMaps to include the new toggle, defaulting it to false to reduce alert noise.
  • Script and Documentation Updates: Modified run_website_cron_tests.sh to respect the new environment variable and updated relevant README files to reflect the deprecation status.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new configuration parameter, "enableNodejs" (mapped to the "ENABLE_NODEJS" environment variable), to conditionally control the execution of Node.js query tests during cron testing. It defaults to "false" pending the deprecation of the Node.js server. The changes span across the cron test runner script, Helm chart templates and values, GKE job templates, and documentation. I have no feedback to provide as there are no review comments to evaluate.

@n-h-diaz
n-h-diaz requested a review from beets August 5, 2026 23:02
@n-h-diaz
n-h-diaz requested review from juliawu and nick-nlb August 7, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant