[oncall cleanup] Disable periodic Node.js query testing - #6567
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a mechanism to disable periodic Node.js query tests in automated GKE cron executions. By adding an explicit configuration toggle, the change aims to reduce test churn and alert noise while the Node.js server is being prepared for deprecation. Manual testing remains fully supported via existing workflows. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new configuration parameter, "enableNodejs" (mapped to the "ENABLE_NODEJS" environment variable), to conditionally control the execution of Node.js query tests during cron testing. It defaults to "false" pending the deprecation of the Node.js server. The changes span across the cron test runner script, Helm chart templates and values, GKE job templates, and documentation. I have no feedback to provide as there are no review comments to evaluate.
Turn down periodic Node.js query testing across automated builds
Description
This change introduces an explicit toggle (
enableNodejs: false) to disable periodic Node.js query tests in automated GKE cron executions by default. This reduces automated test churn and email alert noise fromdatacommons-alerts+tests@google.comwhile the Node.js server is scheduled for future deprecation. Manual testing remains fully supported via existing CLI scripts or by toggling the flag.Changes
enableNodejs: falseto default Helm configuration invalues.yamland explicitly undercronTestinginautopush.yaml.enableNodejsin thecron-testing-configKubernetes ConfigMap and wire theENABLE_NODEJSenvironment variable into the GKE CronJob template.run_website_cron_tests.shto checkENABLE_NODEJS == "true"before running query tests and differ notifications.gke/README.mdandtools/nl/nodejs_query_differ/README.mdexplaining the test toggle and deprecation status.