update the timeout for running embeddings#2049
Merged
shixiao-coder merged 6 commits intoMay 29, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable timeout parameter for Spanner queries in the ingestion helper. It updates the get_updated_nodes and generate_embeddings_partitioned functions to accept a timeout parameter, defaulting to 300 seconds if not provided. In main.py, a new command-line flag timeout is defined with a default of 3600 seconds and passed to these functions. Feedback suggests reducing the default timeout flag value from 3600 to 1800 seconds to align with Google Cloud Workflows' maximum HTTP request timeout limit.
…r than the cloud workflow HTTP max timeout
gmechali
reviewed
May 29, 2026
gmechali
reviewed
May 29, 2026
gmechali
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.