This commit update the model endpoint, embedding index and timestamp field to use.#2046
Merged
shixiao-coder merged 2 commits intoMay 28, 2026
Conversation
…field to use. The recent workflow finishes properly with above fixes and the NodeEmbedding table now generates the embeddings. We also confirm the last_update_timestamp get properly write from data ingestion
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the database schema, utility functions, and Spanner client configuration. Specifically, it removes the flat_index option from the NodeEmbeddingIndex in the SQL schema, updates the timestamp field name from update_timestamp to last_update_timestamp in embedding_utils.py, and modifies the _EMBEDDING_MODEL_PATH in spanner_client.py to use a fully qualified URI. There are no review comments to address, and I have no feedback to provide.
gmechali
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent workflow finishes properly with above fixes and the NodeEmbedding table now generates the embeddings. We also confirm the last_update_timestamp get properly write from data ingestion
Workflow link: https://pantheon.corp.google.com/workflows/workflow/us-central1/xs-ebd-dc-ingestion-workflow/execution/09266b03-e1b0-430b-a7c5-ba0c8f271864/summary?e=13803378&mods=-monitoring_api_staging&project=datcom-website-dev