changed rule to new rule Bls_cpi_Category#2044
Open
niveditasing wants to merge 3 commits into
Open
Conversation
niveditasing
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the validation configuration for the US BLS CPI category import by replacing the deleted records count validator with a percentage-based validator. A critical issue was identified where the threshold value was set to 0.1, which translates to an extremely restrictive 0.1% threshold due to the validator's implementation using a 0-100 scale. It is recommended to change this threshold to 10 to represent a 10% limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the threshold rule ID. This import previously had a threshold of 1230 with rule id that checks deletions in numbers, but because the rule was recently changed to check the deletion threshold as a percentage rather than a raw number, the import is currently failing due to deletions.
Fix: Added the relevant rule ID and set the threshold to 0.6% (representing 1,230 rows out of 211,256).
1230/211256 x 100 ~ 0.58223% ~ 0.6%Keeping the threshold at this level ensures we capture a meaningful baseline of the data without letting minor anomalies skew the results.