WHO Tuberculosis Rifampicin Resistant Import Data#2042
Open
pravnkumar-cloudsufi wants to merge 4 commits into
Open
WHO Tuberculosis Rifampicin Resistant Import Data#2042pravnkumar-cloudsufi wants to merge 4 commits into
pravnkumar-cloudsufi wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new statistical variable import for WHO Tuberculosis treatment outcomes of people with rifampicin-resistant TB. The feedback identifies several critical consistency issues, including duplicate files (such as mainfest.json and who_data_download_tuberculosis_rifampicin_resistant.py), mismatched script and directory paths between manifest.json and README.md, and incorrect test data references. Additionally, the data download script should raise exceptions on HTTP errors to fail loudly in automated environments rather than returning silently, and hardcoded paths should be avoided to prevent brittle execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist: https://docs.google.com/spreadsheets/d/1DP2SvoEwoU6VXvKucE9xiABKRVDzEx-D/edit?usp=drive_link&ouid=112402773742366011389&resourcekey=0-AaGcMXwYDzrz9obQi2_JbQ&rtpof=true&sd=true