Skip to content

WHO Tuberculosis Rifampicin Resistant Import Data#2042

Open
pravnkumar-cloudsufi wants to merge 4 commits into
datacommonsorg:masterfrom
pravnkumar-cloudsufi:tuberculosis_rifampicin_resistant
Open

WHO Tuberculosis Rifampicin Resistant Import Data#2042
pravnkumar-cloudsufi wants to merge 4 commits into
datacommonsorg:masterfrom
pravnkumar-cloudsufi:tuberculosis_rifampicin_resistant

Conversation

@pravnkumar-cloudsufi
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new statistical variable import for WHO Tuberculosis treatment outcomes of people with rifampicin-resistant TB. The feedback identifies several critical consistency issues, including duplicate files (such as mainfest.json and who_data_download_tuberculosis_rifampicin_resistant.py), mismatched script and directory paths between manifest.json and README.md, and incorrect test data references. Additionally, the data download script should raise exceptions on HTTP errors to fail loudly in automated environments rather than returning silently, and hardcoded paths should be avoided to prevent brittle execution.

Comment thread statvar_imports/tuberculosis_rifampicin_resistant/mainfest.json
Comment thread statvar_imports/tuberculosis_rifampicin_resistant/manifest.json Outdated
Comment thread statvar_imports/tuberculosis_rifampicin_resistant/manifest.json Outdated
Comment thread statvar_imports/tuberculosis_rifampicin_resistant/README.md
Comment thread statvar_imports/tuberculosis_rifampicin_resistant/README.md Outdated
Comment thread statvar_imports/tuberculosis_rifampicin_resistant/README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants