Exclude inactive members/consortium organizations from query to fix counts #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The current totals for each type of member include both active and inactive members, although these were excluded from the list. This resulted in a discrepancy between the number of members displayed (e.g., 69 consortia) and the number of members in the list (e.g., 66 consortia). See this Slack thread for context: https://datacite.slack.com/archives/C0CFZNZFE/p1765859289154879
Approach
Update the queries to filter for is_active=true. This is encoded as
is_active=\u0001.Open Questions and Pre-Merge TODOs
I'm not set up with Wordpress to test this locally. Therefore, this should be tested on staging to make sure it doesn't break anything before merging into production.
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: