Skip to content

Conversation

@KellyStathis
Copy link

@KellyStathis KellyStathis commented Dec 16, 2025

Purpose

The current totals for each type of member include both active and inactive members, although these were excluded from the list. This resulted in a discrepancy between the number of members displayed (e.g., 69 consortia) and the number of members in the list (e.g., 66 consortia). See this Slack thread for context: https://datacite.slack.com/archives/C0CFZNZFE/p1765859289154879

Approach

Update the queries to filter for is_active=true. This is encoded as is_active=\u0001.

Open Questions and Pre-Merge TODOs

I'm not set up with Wordpress to test this locally. Therefore, this should be tested on staging to make sure it doesn't break anything before merging into production.

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@KellyStathis
Copy link
Author

@paulvierkant I hope this fix will work but I haven't tested it in Wordpress myself. If it makes sense to work on, maybe you or Daniel could check it and merge?

@paulvierkant
Copy link
Collaborator

Thanks @KellyStathis, I will check together with @danielauener!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants