-
Notifications
You must be signed in to change notification settings - Fork 41
Added validation for HW_Changes_bit_check - CSCvv04251 #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asraf-khan
wants to merge
6
commits into
datacenter:master
Choose a base branch
from
asraf-khan:issue1-CSCvv04251
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return Result(result=result, headers=headers, data=data, recommended_action=recommended_action, doc_url=doc_url) | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic is not following format of the old script. please follow the same structure
kahande
reviewed
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIC Run output for positive case where All matched model Nodes HW Changes bit meet the requirement:
python aci-preupgrade-validation-script.py -d HW_changes_bit_check -t "14.2(5a)"
==== 2025-12-03T02-14-58-0800, Script Version v4.0.0 ====
!!!! Check https://github.com/datacenter/ACI-Pre-Upgrade-Validation-Script for Latest Release !!!!
To use a non-default Login Domain, enter apic#DOMAIN\USERNAME
Enter username for APIC login : admin
\Enter password for corresponding User :
Gathering Node Information...
Current APIC Version...6.2(0.167)
Lowest Switch Version...6.1(4h)
Target APIC version is overridden to 14.2(5a)
Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |----------------------------------------------------------------------------------------------------| 0/1 Progress: |████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 checks completed
=== Check Result (failed only) ===
=== Summary Result ===
PASS : 1
FAIL - OUTAGE WARNING!! : 0
FAIL - UPGRADE FAILURE!! : 0
MANUAL CHECK REQUIRED : 0
POST UPGRADE CHECK REQUIRED : 0
N/A : 0
ERROR !! : 0
TOTAL : 1
==== Script Version v4.0.0 FIN ====
APIC Run output for Negative scenario where All Matched model Nodes HW Changes bit doesn't meet the requirement:
python aci-preupgrade-validation-script.py -d HW_changes_bit_check -t "14.2(5a)"
==== 2025-12-03T02-22-05-0800, Script Version v4.0.0 ====
!!!! Check https://github.com/datacenter/ACI-Pre-Upgrade-Validation-Script for Latest Release !!!!
To use a non-default Login Domain, enter apic#DOMAIN\USERNAME
Enter username for APIC login : admin
Enter password for corresponding User :
Gathering Node Information...
Current APIC Version...6.2(0.167)
Lowest Switch Version...6.1(4h)
Target APIC version is overridden to 14.2(5a)
Progress: |████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 checks completed
=== Check Result (failed only) ===
[Check 1/1] HW Changes bit check for specific node model... FAIL - OUTAGE WARNING!!
Node Model HW Changes Bits Recommended Action
ifav42-spine6 N9K-C9316D-GX 0x3 This switch need Manual Upgrade (CSCvv04251). Contact TAC for Support
ifav42-spine8 N9K-C93600CD-GX 0x2 This switch need Manual Upgrade (CSCvv04251). Contact TAC for Support
ifav42-spine9 N9K-C93600CD-GX 0x2 This switch need Manual Upgrade (CSCvv04251). Contact TAC for Support
Recommended Action: Contact Cisco TAC for Support before upgrade
Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#HW_changes_bit_check
=== Summary Result ===
PASS : 0
FAIL - OUTAGE WARNING!! : 1
FAIL - UPGRADE FAILURE!! : 0
MANUAL CHECK REQUIRED : 0
POST UPGRADE CHECK REQUIRED : 0
N/A : 0
ERROR !! : 0
TOTAL : 1
==== Script Version v4.0.0 FIN ====