-
Notifications
You must be signed in to change notification settings - Fork 41
issue NewValidation: For N9K-C93180YC-FX3 check for 16 GB of RAM vs 32 GB #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
jeestr4d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pytest results:
====================================================================================== test session starts ======================================================================================
platform darwin -- Python 3.9.6, pytest-8.2.0, pluggy-1.5.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
plugins: anyio-4.8.0
collected 7 items
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs0-None-MANUAL CHECK REQUIRED]
---------------------------------------------------------------------------------------- live log setup -----------------------------------------------------------------------------------------
[15:25:19.587 INFO initialize:5353] Cleaning up previous run files in preupgrade_validator_logs/
[15:25:19.588 INFO initialize:5355] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
PASSED [ 14%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs1-6.0(9c)-N/A] PASSED [ 28%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs2-6.1(1f)-N/A] PASSED [ 42%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs3-6.0(9d)-PASS] PASSED [ 57%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs4-6.1(2f)-PASS] PASSED [ 71%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs5-6.0(9d)-FAIL - OUTAGE WARNING!!] PASSED [ 85%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs6-6.1(2f)-FAIL - OUTAGE WARNING!!] PASSED [100%]
======================================================================================= 7 passed in 0.03s =======================================================================================
Lab results, with condition as ">=32000000" instead:
[Check 87/87] N9K-C93180YC-FX3 Sup Memory... FAIL - OUTAGE WARNING!!
NodeId Name Memory Detected (GB)
101 a1-leaf1 31.03
103 a1-leaf3 31.03
normal condition:
[Check 87/87] N9K-C93180YC-FX3 Sup Memory... PASS
aci-preupgrade-validation-script.py
Outdated
| headers = ["NodeId", "Name", "Memory Detected (GB)"] | ||
| data = [] | ||
| recommended_action = 'Review the Memory Installed in your N9K-C93180YC-FX3 Switches' | ||
| doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#isis-dteps-byte-size' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jeestr4d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc_url corrected
Fixes #280 fixed