Skip to content

Conversation

@jeestr4d
Copy link
Collaborator

Fixes #280 fixed

Copy link
Collaborator Author

@jeestr4d jeestr4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pytest results:

====================================================================================== test session starts ======================================================================================
platform darwin -- Python 3.9.6, pytest-8.2.0, pluggy-1.5.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
plugins: anyio-4.8.0
collected 7 items

tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs0-None-MANUAL CHECK REQUIRED]
---------------------------------------------------------------------------------------- live log setup -----------------------------------------------------------------------------------------
[15:25:19.587 INFO initialize:5353] Cleaning up previous run files in preupgrade_validator_logs/
[15:25:19.588 INFO initialize:5355] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
PASSED [ 14%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs1-6.0(9c)-N/A] PASSED [ 28%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs2-6.1(1f)-N/A] PASSED [ 42%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs3-6.0(9d)-PASS] PASSED [ 57%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs4-6.1(2f)-PASS] PASSED [ 71%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs5-6.0(9d)-FAIL - OUTAGE WARNING!!] PASSED [ 85%]
tests/n9k_c93108yc_fx3_mem_check/test_n9k_c93108yc_fx3_mem_check.py::test_logic[icurl_outputs6-6.1(2f)-FAIL - OUTAGE WARNING!!] PASSED [100%]

======================================================================================= 7 passed in 0.03s =======================================================================================

Lab results, with condition as ">=32000000" instead:

[Check 87/87] N9K-C93180YC-FX3 Sup Memory... FAIL - OUTAGE WARNING!!
NodeId Name Memory Detected (GB)


101 a1-leaf1 31.03
103 a1-leaf3 31.03

normal condition:

[Check 87/87] N9K-C93180YC-FX3 Sup Memory... PASS

headers = ["NodeId", "Name", "Memory Detected (GB)"]
data = []
recommended_action = 'Review the Memory Installed in your N9K-C93180YC-FX3 Switches'
doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#isis-dteps-byte-size'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@jeestr4d jeestr4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc_url corrected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NewValidation: For N9K-C93180YC-FX3 check for 16 GB of RAM vs 32 GB

2 participants