issue264 fixed #278
Open
issue264 fixed #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #264 fixed.
local pytest results:
jeestrad@JEESTRAD-M-L6VV ACI-Pre-Upgrade-Validation-Script % python3 -m pytest tests/auto_firmware_update_ondiscovery_check
======================================================================== test session starts =========================================================================
platform darwin -- Python 3.9.6, pytest-8.2.0, pluggy-1.5.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
plugins: anyio-4.8.0
collected 9 items
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs0-None-None-MANUAL CHECK REQUIRED]
--------------------------------------------------------------------------- live log setup ---------------------------------------------------------------------------
[11:01:52.381 INFO initialize:5347] Cleaning up previous run files in preupgrade_validator_logs/
[11:01:52.382 INFO initialize:5349] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
PASSED [ 11%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs1-5.2(7a)-None-MANUAL CHECK REQUIRED] PASSED [ 22%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs2-None-6.0(3d)-MANUAL CHECK REQUIRED] PASSED [ 33%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs3-5.2(7a)-6.0(2d)-N/A] PASSED [ 44%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs4-6.0(3a)-6.0(9d)-N/A] PASSED [ 55%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs5-5.2(7a)-6.0(3d)-FAIL - OUTAGE WARNING!!] PASSED [ 66%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs6-6.0(2a)-6.0(3d)-FAIL - OUTAGE WARNING!!] PASSED [ 77%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs7-5.2(7a)-6.0(3d)-PASS] PASSED [ 88%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs8-5.2(7a)-6.0(3d)-PASS] PASSED [100%]
========================================================================= 9 passed in 0.06s ==========================================================================
result from lab:
[Check 87/87] Auto Firmware Update on Switch Discovery... FAIL - OUTAGE WARNING!!
Auto firmware Policy Dn Switch enforced Version
uni/fabric/fwrepop n9000-16.0(8f)
Recommended Action: Disable the Auto Firmware Update on Switch Discovery policy before upgrade
Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#auto-firmware-update-on-switch-discovery