Welkin large db v31 #266
Merged
Welkin large db v31 #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clean up get_vpc_nodes() and its pytest * Split the main script execution code into each func and add pytest * Retire json_log and adopt json per rule for both PUV and regular use + linting
…on (#259) * feat: Support QA version and AciVersion instance as input in AciVersion * fix: Use supported version format in older_than * fix: Use ValueError in AciVersion
* -c (cversion) and -d (debug_function) for dev testing * pytest fix WIP * fixed pytest
A new decorator `@check_wrapper` is to move most of the I/O functionalities, such as printing and writing the result into a file, outside of each check function so that each check can focus on the validation logic itself by minimizing the impact from a requirement change in the output format and so on. To support this, a new class `Result` is also introduced to make it clear what a check function is expected to return. As long as `Result` class is returned, the decorator `@check_wrapper` handles the printing them to stdout and files.
monrog2
requested changes
Jul 23, 2025
Collaborator
monrog2
left a comment
monrog2
left a comment
There was a problem hiding this comment.
Review changes / questions. Use the new pytest cmd_outputs fixture for subprocess check uniformity, let me know if you have questions/suggestions on it.
Collaborator
There was a problem hiding this comment.
update pytest dir + filename to match function name update
Applied the same naming change to test. Changes to be committed: modified: aci-preupgrade-validation-script.py modified: docs/docs/validations.md renamed: tests/large_apic_database_check/infraWiNode.json -> tests/apic_database_size_check/infraWiNode.json renamed: tests/large_apic_database_check/test_large_apic_database_check.py -> tests/apic_database_size_check/test_large_apic_database_check.py Changes not staged for commit: modified: aci-preupgrade-validation-script.py modified: tests/apic_database_size_check/test_large_apic_database_check.py
monrog2
previously approved these changes
Jul 25, 2025
Collaborator
monrog2
left a comment
monrog2
left a comment
There was a problem hiding this comment.
pytests good, intergration tests good. merging
monrog2
approved these changes
Jul 25, 2025
Collaborator
monrog2
left a comment
monrog2
left a comment
There was a problem hiding this comment.
good for real this time
Collaborator
|
latest pytest output: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.