Conversation
|
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@swamimalode07 is attempting to deploy a commit to the Databuddy OSS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR is a visual refresh of the docs site navbar. It restructures the layout so nav links are absolutely centered in the bar, separates utility items (GitHub, theme toggle, CTA) into a dedicated right-side container, increases the bar height from Two functional bugs were found:
Confidence Score: 2/5Not safe to merge — content is clipped behind the navbar due to the spacer height mismatch, and font sizing is broken across four nav components. Two user-visible functional regressions: (1) the spacer height wasn't updated to match the taller navbar, causing every docs page to have content hidden behind the header; (2) text-md is an invalid Tailwind class silently ignored everywhere it appears. These need to be fixed before merging. apps/docs/components/navbar.tsx (spacer height bug at line 136-137); apps/docs/components/nav-link.tsx, navbar-features-menu.tsx, github-nav-mark.tsx, and the CTA in navbar.tsx (all use invalid text-md class) Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Fixed Header - h-20 / 80px"] --> B["Nav Row - relative flex h-20"]
B --> C["Logo — shrink-0 left"]
B --> D["pointer-events-none absolute inset-x-0\ncentered nav links"]
B --> E["ml-auto hidden md:block\nright-side utilities"]
B --> F["ml-auto md:hidden\nMobile Menu Button"]
D --> G["NavbarFeaturesMenu"]
D --> H["NavLink items × N"]
E --> I["NavbarGithubDesktopLink\nborder pill"]
E --> J["ThemeToggle size-10"]
E --> K["Start free CTA"]
A --> L["Mobile Drawer - md:hidden"]
A -->|"Spacer below header"| M["❌ h-4rem / 64px — too short"]
M -->|"Should be"| N["✅ h-5rem / 80px"]
|
apps/docs/components/nav-link.tsx
Outdated
| <Component | ||
| className={cn( | ||
| "flex items-center gap-2 px-4 py-4 font-medium text-muted-foreground text-sm hover:text-foreground", | ||
| "flex items-center gap-2 px-4 py-5 font-medium text-foreground/70 text-md hover:text-foreground", |
There was a problem hiding this comment.
text-md is not a valid Tailwind CSS utility
text-md does not exist in Tailwind CSS (v3 or v4) and is not defined as a custom utility anywhere in this project — there is no tailwind.config.* file and global.css has no text-md definition. Tailwind will silently ignore it, so no font-size will be applied to these elements. The standard equivalent for base/medium text is text-base (1rem).
This same invalid class appears in multiple places across the PR:
apps/docs/components/navbar-features-menu.tsx:92apps/docs/components/github-nav-mark.tsx:30apps/docs/components/navbar.tsx:59
| "flex items-center gap-2 px-4 py-5 font-medium text-foreground/70 text-md hover:text-foreground", | |
| "flex items-center gap-2 px-4 py-5 font-medium text-foreground/70 text-base hover:text-foreground", |
| <span | ||
| className="rounded-full border border-border/50 bg-muted/50 px-2.5 py-0.5 font-medium text-foreground/90 text-xs" | ||
| className="rounded-full px-1 py-0.5 pt-1 font-medium text-foreground text-md" | ||
| title="GitHub stars" |
There was a problem hiding this comment.
Redundant padding utilities on
GithubStarsBadge
py-0.5 sets both top and bottom padding to 0.125rem, but pt-1 then overrides the top to 0.25rem. While CSS cascade makes this work, it is confusing to read. Prefer explicit pb-0.5 pt-1 to make the intent clear:
| <span | |
| className="rounded-full border border-border/50 bg-muted/50 px-2.5 py-0.5 font-medium text-foreground/90 text-xs" | |
| className="rounded-full px-1 py-0.5 pt-1 font-medium text-foreground text-md" | |
| title="GitHub stars" | |
| <span | |
| className="rounded-full pb-0.5 pt-1 px-1 font-medium text-foreground text-base" | |
| title="GitHub stars" | |
| > |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
Checklist