Skip to content

Landing Page Revamp#382

Draft
swamimalode07 wants to merge 6 commits intodatabuddy-analytics:mainfrom
swamimalode07:feature/landing-revamp
Draft

Landing Page Revamp#382
swamimalode07 wants to merge 6 commits intodatabuddy-analytics:mainfrom
swamimalode07:feature/landing-revamp

Conversation

@swamimalode07
Copy link
Copy Markdown

@swamimalode07 swamimalode07 commented Apr 4, 2026

Description

Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.

Checklist
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b03b964c-928d-4913-8789-d2766718b54f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2026

@swamimalode07 is attempting to deploy a commit to the Databuddy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – dashboard April 4, 2026 20:34 Inactive
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
dashboard Skipped Skipped Apr 9, 2026 6:00pm

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 4, 2026

Greptile Summary

This PR is a visual refresh of the docs site navbar. It restructures the layout so nav links are absolutely centered in the bar, separates utility items (GitHub, theme toggle, CTA) into a dedicated right-side container, increases the bar height from h-16 to h-20, bumps font/icon/button sizes, removes the translucent header border in favour of a solid background, and lightens the dark-mode background token.

Two functional bugs were found:

  • Spacer height mismatch (navbar.tsx:136): The navbar grew from h-16 (4rem) to h-20 (5rem) but the spacer div that offsets page content still calculates 4rem, so all page content will be 16px obscured behind the fixed header.
  • Invalid Tailwind class text-md used in nav-link.tsx, navbar-features-menu.tsx, github-nav-mark.tsx, and navbar.tsx (CTA button): text-md is not a valid Tailwind utility in any version and is not defined as a custom utility in this project. Text size styling is silently dropped; the intended class is likely text-base.
  • Minor: redundant py-0.5 pt-1 padding in GithubStarsBadge is confusing (works but should be written as pb-0.5 pt-1).
  • ⚠️ The PR description is empty and the checklist is entirely unchecked — the author should document the intent of the changes per project contribution guidelines.

Confidence Score: 2/5

Not safe to merge — content is clipped behind the navbar due to the spacer height mismatch, and font sizing is broken across four nav components.

Two user-visible functional regressions: (1) the spacer height wasn't updated to match the taller navbar, causing every docs page to have content hidden behind the header; (2) text-md is an invalid Tailwind class silently ignored everywhere it appears. These need to be fixed before merging.

apps/docs/components/navbar.tsx (spacer height bug at line 136-137); apps/docs/components/nav-link.tsx, navbar-features-menu.tsx, github-nav-mark.tsx, and the CTA in navbar.tsx (all use invalid text-md class)

Important Files Changed

Filename Overview
apps/docs/components/navbar.tsx Layout refactored to center nav links absolutely and separate right-side utilities; spacer height not updated to match new h-20 navbar, causing content overlap
apps/docs/components/nav-link.tsx Padding and color updated; text-sm replaced with non-existent text-md Tailwind utility
apps/docs/components/navbar-features-menu.tsx Button padding and text style harmonised with nav links; uses invalid text-md utility
apps/docs/components/github-nav-mark.tsx Stars badge border/bg removed (delegated to parent); redundant py-0.5+pt-1 padding and invalid text-md class added
apps/docs/components/navbar-github-desktop-link.tsx GitHub icon+stars now wrapped in a bordered rounded-md pill container; clean visual update
apps/docs/components/theme-toggle.tsx Button and icon sizes increased from size-8/size-4 to size-10/size-5 to match the taller navbar
apps/docs/app/global.css Dark mode --background lightened from #19191D to #27282D; intentional palette alignment

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Fixed Header - h-20 / 80px"] --> B["Nav Row - relative flex h-20"]
    B --> C["Logo — shrink-0 left"]
    B --> D["pointer-events-none absolute inset-x-0\ncentered nav links"]
    B --> E["ml-auto hidden md:block\nright-side utilities"]
    B --> F["ml-auto md:hidden\nMobile Menu Button"]
    D --> G["NavbarFeaturesMenu"]
    D --> H["NavLink items × N"]
    E --> I["NavbarGithubDesktopLink\nborder pill"]
    E --> J["ThemeToggle size-10"]
    E --> K["Start free CTA"]
    A --> L["Mobile Drawer - md:hidden"]
    A -->|"Spacer below header"| M["❌ h-4rem / 64px — too short"]
    M -->|"Should be"| N["✅ h-5rem / 80px"]
Loading

Comments Outside Diff (1)

  1. apps/docs/components/navbar.tsx, line 136-137 (link)

    P1 Spacer height not updated to match new navbar height

    The navbar height was increased from h-16 (64px / 4rem) to h-20 (80px / 5rem), but the spacer div immediately below the <header> still uses h-[calc(4rem+env(safe-area-inset-top,0px))]. This 16px gap means page content will be partially hidden behind the fixed navbar on every page of the docs site.

Reviews (1): Last reviewed commit: "navbar fixed" | Re-trigger Greptile

<Component
className={cn(
"flex items-center gap-2 px-4 py-4 font-medium text-muted-foreground text-sm hover:text-foreground",
"flex items-center gap-2 px-4 py-5 font-medium text-foreground/70 text-md hover:text-foreground",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 text-md is not a valid Tailwind CSS utility

text-md does not exist in Tailwind CSS (v3 or v4) and is not defined as a custom utility anywhere in this project — there is no tailwind.config.* file and global.css has no text-md definition. Tailwind will silently ignore it, so no font-size will be applied to these elements. The standard equivalent for base/medium text is text-base (1rem).

This same invalid class appears in multiple places across the PR:

  • apps/docs/components/navbar-features-menu.tsx:92
  • apps/docs/components/github-nav-mark.tsx:30
  • apps/docs/components/navbar.tsx:59
Suggested change
"flex items-center gap-2 px-4 py-5 font-medium text-foreground/70 text-md hover:text-foreground",
"flex items-center gap-2 px-4 py-5 font-medium text-foreground/70 text-base hover:text-foreground",

Comment on lines 29 to 31
<span
className="rounded-full border border-border/50 bg-muted/50 px-2.5 py-0.5 font-medium text-foreground/90 text-xs"
className="rounded-full px-1 py-0.5 pt-1 font-medium text-foreground text-md"
title="GitHub stars"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Redundant padding utilities on GithubStarsBadge

py-0.5 sets both top and bottom padding to 0.125rem, but pt-1 then overrides the top to 0.25rem. While CSS cascade makes this work, it is confusing to read. Prefer explicit pb-0.5 pt-1 to make the intent clear:

Suggested change
<span
className="rounded-full border border-border/50 bg-muted/50 px-2.5 py-0.5 font-medium text-foreground/90 text-xs"
className="rounded-full px-1 py-0.5 pt-1 font-medium text-foreground text-md"
title="GitHub stars"
<span
className="rounded-full pb-0.5 pt-1 px-1 font-medium text-foreground text-base"
title="GitHub stars"
>

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@vercel vercel bot temporarily deployed to Preview – dashboard April 4, 2026 20:48 Inactive
@swamimalode07 swamimalode07 marked this pull request as draft April 4, 2026 20:53
@swamimalode07 swamimalode07 changed the title navbar fixed Landing Page Revamp Apr 4, 2026
@vercel vercel bot temporarily deployed to Preview – dashboard April 5, 2026 19:03 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard April 7, 2026 15:31 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard April 9, 2026 12:31 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard April 9, 2026 18:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants