Support per-client skill MCP scopes - #520
Draft
xsh310 wants to merge 1 commit into
Draft
Conversation
Store the skills MCP connection's scope as a per-client map (`skill_locations_by_client`) instead of a single flat `skill_locations` list, so `skill add`/`skill remove` can target individual agents. Reads fall back to the flat list, mirrored to every client, for connections written by older builds; `skill_locations` is kept as the union mirror. Co-authored-by: Arthur Jenoudet <arthur.jenoudet@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Store the skills MCP connection's scope as a per-client map (
skill_locations_by_client) instead of a single flatskill_locationslist, soskill add/skill removecan target individual coding agents. Reads fall back to the flat list (mirrored to every client) for connections written by older builds, andskill_locationsis kept as the union mirror for legacy readers.Stacking
Stacked on #519 (
skill-managed-download-only). With managed skills delivered by download only (that PR), the skills MCP connection holds just a developer's ownskill add --mcpschemas, so the per-client scope is purely developer state — no global managed set to union in.This is the first PR of a fresh per-agent skills stack that mirrors the structure of the original stack (skill-agent-scopes → add → status → remove → …), rebuilt on top of the managed-removal PR. Base will move to
mainonce #519 merges.Original design and initial implementation by Arthur Jenoudet; reworked into the per-client model here.
This pull request and its description were written by Isaac.