Skip to content

perf: single-pass std.sum/std.avg without intermediate array #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenamar-db merged 1 commit into from
Apr 21, 2026
Merged

perf: single-pass std.sum/std.avg without intermediate array #782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions sjsonnet/src/sjsonnet/stdlib/ArrayModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,19 +736,33 @@ object ArrayModule extends AbstractFunctionModule {
)
},
builtin("sum", "arr") { (_, _, arr: Val.Arr) =>
if (!arr.forall(_.isInstanceOf[Val.Num])) {
Error.fail("Argument must be an array of numbers")
val a = arr.asLazyArray
var sum = 0.0
var i = 0
while (i < a.length) {
a(i).value match {
case n: Val.Num => sum += n.asDouble
case x => Error.fail("std.sum expected number, got " + x.prettyName)
}
i += 1
}
arr.asLazyArray.map(_.value.asDouble).sum
sum
},
builtin("avg", "arr") { (_, _, arr: Val.Arr) =>
if (!arr.forall(_.isInstanceOf[Val.Num])) {
Error.fail("Argument must be an array of numbers")
}
if (arr.length == 0) {
val a = arr.asLazyArray
if (a.length == 0) {
Error.fail("Cannot calculate average of an empty array")
}
arr.asLazyArray.map(_.value.asDouble).sum / arr.length
var sum = 0.0
var i = 0
while (i < a.length) {
a(i).value match {
case n: Val.Num => sum += n.asDouble
case x => Error.fail("std.avg expected number, got " + x.prettyName)
}
i += 1
}
sum / a.length
}
)
}
Loading