fix: stop emitting insert_overwrite noise warning on every run (#1305)#1425
Open
fix: stop emitting insert_overwrite noise warning on every run (#1305)#1425
Conversation
Previously, every insert_overwrite run on a SQL warehouse emitted "insert_overwrite will perform a dynamic insert overwrite..." even though SQL warehouses always support REPLACE ON. The warning had no actionable signal once a user opted into the default behavior flag. Move the warning to the only case where it has signal: cluster compute on DBR < 17.1 with use_replace_on_for_insert_overwrite=True, where the user expected REPLACE ON but the runtime can't deliver it and we fall back to legacy INSERT OVERWRITE.
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1305 partially
Every
insert_overwriterun on a SQL warehouse was emitting:Once a user is on the default
use_replace_on_for_insert_overwrite=True, this carries no actionable signal — it just spams the run log on every model.Change
REPLACE ON, so there's nothing to warn about.use_replace_on_for_insert_overwrite=True. There, the user opted into REPLACE ON but the runtime falls back to legacyINSERT OVERWRITE— that mismatch is worth surfacing.Test plan
insert_overwriteruns no longer emit the warning. Pre-fix code with the same harness confirmed the warning fired (test failed); fixed code confirmed silence (test passed).TestInsertOverwriteWithPartitionsDeltastill passes — no behavioral regression.