Skip to content

WIP: Code conventions for new code matching existing style#2043

Open
misha-db wants to merge 3 commits into
mainfrom
code-conventions
Open

WIP: Code conventions for new code matching existing style#2043
misha-db wants to merge 3 commits into
mainfrom
code-conventions

Conversation

@misha-db

Copy link
Copy Markdown
Contributor

Changes

Describes existing code style and naming conventions. So new code can follow the same principles

Tests

Manually

@misha-db
misha-db requested a review from rugpanov July 23, 2026 14:37
@misha-db misha-db self-assigned this Jul 23, 2026
@misha-db
misha-db temporarily deployed to test-trigger-is July 23, 2026 14:37 — with GitHub Actions Inactive
@misha-db
misha-db temporarily deployed to test-trigger-is July 23, 2026 14:37 — with GitHub Actions Inactive
@rugpanov

Copy link
Copy Markdown
Contributor

🤖 Integration tests triggered for 550887e6 — ⏳ running.
View run

@rugpanov

rugpanov commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🤖 Integration tests ✅ all 35 test jobs passed for 0244fc9c.
View run

@rugpanov rugpanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, accurate onboarding doc — the suffix taxonomy, DI, event/disposal idioms, vscode-objs/ seam, decorators, and test suffixes all match the codebase. A few additions from a recent structural audit that fill gaps here, all consistent with the "match the current setup" framing (no new abstractions):

Comment thread CODE_CONVENTIONS.md
Comment thread CODE_CONVENTIONS.md
Comment thread CODE_CONVENTIONS.md

@rugpanov rugpanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more, focused on navigation (finding where a feature lives / where to add code):

Comment thread CODE_CONVENTIONS.md Outdated
Comment thread CODE_CONVENTIONS.md
Comment thread CODE_CONVENTIONS.md
@misha-db
misha-db temporarily deployed to test-trigger-is July 24, 2026 14:45 — with GitHub Actions Inactive
@misha-db
misha-db deployed to test-trigger-is July 24, 2026 14:45 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/vscode

Inputs:

  • PR number: 2043
  • Commit SHA: b5f727b5b2434f21620d4129bf286e3a23724c75

Checks will be approved automatically on success.

@rugpanov

Copy link
Copy Markdown
Contributor

🤖 Integration tests triggered for b5f727b5 — ⏳ running.
View run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants