Merge SeaHttpClient into THttpClient

[varun-edachali-dbx]

What type of PR is this?

• Feature

Description

Currently, the SeaDatabricksClient uses a simple SeaHttpClient, which helped us introduce SEA features in isolation without having to worry about the HTTP Client details.

To allow the re-use of implemented auth and efficiency features in the THttpClient, we aim to re-use it in the SEA client and eliminate the old SeaHttpClient.

How is this tested?

• Unit tests
• E2E Tests
• Manually - using the test scripts as modified in Complete Fetch Phase (for INLINE disposition and JSON_ARRAY format) #594
• N/A

The coverage of the newly introduced methods in THttpClient by test_thrift_http_client.py is as below:

Module	Function	Line Range	Statements	Missing	Coverage	Notes
thrift_http_client.py	make_rest_request	228-339	112	1	99%	Missing coverage in: - Line 321: Logging truncated response content
thrift_http_client.py	_check_rest_response_for_error	340-374	35	0	100%	Fully covered

Related Tickets & Documents

https://docs.google.com/document/d/1Y-eXLhNqqhrMVGnOlG8sdFrCxBTN1GdQvuKG4IfHmo0/edit?usp=sharing

[github-actions]

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

[github-actions]

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

[github-actions]

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

[varun-edachali-dbx]

Superseded by #618.

Decided to create a new, separate HTTP Client for SEA rather than merging into the THttpClient, which is deeply coupled with Thrift.