Skip to content

chore: update vulnerable Node.js dependencies - #522

Merged
vikrantpuppala merged 1 commit into
mainfrom
vp/fix-security-scan-20260909
Sep 9, 2026
Merged

chore: update vulnerable Node.js dependencies#522
vikrantpuppala merged 1 commit into
mainfrom
vp/fix-security-scan-20260909

Conversation

@vikrantpuppala

@vikrantpuppala vikrantpuppala commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Update browserslist from 4.28.4 to 4.28.7 and refresh its required browser-data entries.
  • Update transitive js-yaml 3.x from 3.15.1 to 3.15.2.
  • Update transitive js-yaml 4.x from 4.3.1 to 4.3.2.

These changes address the blocking repository security-scan findings, including GHSA-2883-xcg3-v3hh (CVE-2026-84375).

Testing

  • npm run build
  • npm run prettier
  • env -u CODEX_CI npm test — 1,290 passing
  • npm ls js-yaml --all — resolves only patched 3.15.2 and 4.3.2
  • npm audit — 0 vulnerabilities
  • git diff --check

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@vikrantpuppala
vikrantpuppala force-pushed the vp/fix-security-scan-20260909 branch from ea845a1 to d992d32 Compare September 9, 2026 06:13
@vikrantpuppala vikrantpuppala changed the title chore: update browserslist to 4.28.7 chore: update vulnerable Node.js dependencies Sep 9, 2026
Update browserslist to 4.28.7 and the transitive js-yaml packages to the patched 3.15.2 and 4.3.2 releases.

Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: 1 Medium

Dependency-only lockfile update (security patches for js-yaml plus browserslist data refresh) — mechanically sound, but one medium concern: the js-yaml resolved URLs now point at the internal npm-proxy.cloud.databricks.com host, which will break npm ci for external contributors. Everything else uses the public registry.

Comment thread package-lock.json
"integrity": "sha512-CY6crGq313MX8GkwvB7tzgp99vjQxY1++5y10/BKN/GUfHqWaOGQMNZkBvqSzsZKWk/ijwHlWzzkLulsGHhjWQ==",
"version": "4.3.2",
"resolved": "https://npm-proxy.cloud.databricks.com/js-yaml/-/js-yaml-4.3.2.tgz",
"integrity": "sha512-SFNOvSJ+Dgf/9An904Yx+CgSlIPCkIpao4qo51lpee25TIRejdH3rhR4EZMGoNx3/TP3O+wzWuiTFl4sqbltzA==",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — The refreshed js-yaml entries (both 3.15.2 and 4.3.2, in every nested copy) now have resolved URLs pointing at the internal https://npm-proxy.cloud.databricks.com/... registry instead of the public https://registry.npmjs.org/.... This is a public, widely-consumed open-source connector, so external contributors running npm ci (which installs strictly from the resolved URLs in the lockfile) will fail to fetch these tarballs since the Databricks proxy host is not publicly reachable. The other bumped packages (browserslist, caniuse-lite, etc.) correctly retained registry.npmjs.org, so the js-yaml entries are inconsistent with the rest of the lockfile. Recommend regenerating the lockfile against the public registry so all resolved URLs use registry.npmjs.org. The integrity hashes are content-addressed and will match either way, but the host must be publicly resolvable.

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@vikrantpuppala
vikrantpuppala added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit 28694bc Sep 9, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants