Skip to content

ci: fix dead driver-test workflow link in dispatch comment#460

Closed
eric-wang-1990 wants to merge 1 commit into
mainfrom
ci/fix-dispatch-comment-link
Closed

ci: fix dead driver-test workflow link in dispatch comment#460
eric-wang-1990 wants to merge 1 commit into
mainfrom
ci/fix-dispatch-comment-link

Conversation

@eric-wang-1990

Copy link
Copy Markdown

Summary

The cross-repo dispatch sender comments "Node.js integration tests triggered" on the PR with a link to the driver-test receiver workflow. The link pointed to databricks-nodejs-integration-tests.yml, which does not exist (404) — the actual receiver file is databricks-sql-nodejs-integration-tests.yml (missing sql-).

Fixed the filename and clarified that the authoritative result is the "Node.js Integration Tests" check posted back on the PR (whose details_url links the specific driver-test run — the sender can't link the run directly since repository_dispatch returns no run ID).

Test Plan

  • Corrected target databricks-sql-nodejs-integration-tests.yml resolves 200 on driver-test main
  • Workflow YAML parses; no stale databricks-nodejs-integration-tests.yml reference remains
  • End-to-end flow verified green this session (sender dispatch → receiver run 30073691703 → both thrift+sea legs success → check posted back)

This pull request and its description were written by Isaac.

The "Node.js integration tests triggered" PR comment linked to
databricks-nodejs-integration-tests.yml, which does not exist (404) — the
receiver file is databricks-sql-nodejs-integration-tests.yml. Point to the
correct workflow and note that the authoritative result is the "Node.js
Integration Tests" check posted back on the PR.

Co-authored-by: Isaac
Copilot AI review requested due to automatic review settings July 24, 2026 07:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@eric-wang-1990

Copy link
Copy Markdown
Author

Folded into #459 (same file, trigger-integration-tests.yml). The comment-link 404 fix now rides on that PR's branch; closing this standalone PR.

@eric-wang-1990
eric-wang-1990 deleted the ci/fix-dispatch-comment-link branch July 24, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants