acc: fix change detection skipping new tests on windows/macOS PRs#6047
Open
denik wants to merge 3 commits into
Open
acc: fix change detection skipping new tests on windows/macOS PRs#6047denik wants to merge 3 commits into
denik wants to merge 3 commits into
Conversation
The acceptance subset selector runs `git diff --merge-base origin/main` to always run the tests a PR adds/changes on the windows/macOS cells, but the test job's shallow checkout has no origin/main, so the diff failed and the error was swallowed, silently disabling change detection. Fetch origin/main in CI and fail loudly on a failed diff instead.
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Do not merge. Modifies selftest/basic/script so its golden comparison fails, to confirm from CI logs that change detection runs this test on the windows/macOS subset cells (not skipped by TESTS_SELECT_SUBSET_PCT).
Collaborator
Integration test reportCommit: e113e42
|
This reverts commit d2893a0.
denik
enabled auto-merge
July 23, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Subsetting is enabled only on the windows/macOS PR cells (
TESTS_SELECT_SUBSET_PCT). There the subset selector runsgit diff --merge-base origin/mainto always run the tests a PR adds/changes, but the test job's shallow checkout has no origin/main, so the diff failed — and the error was swallowed, silently disabling change detection. New tests then fell through to the seeded hash and got skipped, which is how b82fa5c's invariant tests passed on PR yet failed on the nightly Windows run.Follow up to #6019
Changes